Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: trunk/src/build/common.gypi

Issue 85523003: Revert 237048 "When building with component=shared_library on li..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/common.gypi
===================================================================
--- trunk/src/build/common.gypi (revision 237059)
+++ trunk/src/build/common.gypi (working copy)
@@ -3488,17 +3488,19 @@
}],
],
}],
- ['component=="shared_library"', {
- # See crbug.com/112389. Also required for BACKTRACE() to work.
- # TODO(glider): replace with --dynamic-list or something
- 'ldflags': ['-rdynamic'],
- }],
['linux_use_heapchecker==1', {
'variables': {'linux_use_tcmalloc%': 1},
'defines': [
'USE_HEAPCHECKER',
'MEMORY_TOOL_REPLACES_ALLOCATOR',
],
+ 'conditions': [
+ ['component=="shared_library"', {
+ # See crbug.com/112389
+ # TODO(glider): replace with --dynamic-list or something
+ 'ldflags': ['-rdynamic'],
+ }],
+ ],
}],
['linux_use_tcmalloc==0 and android_use_tcmalloc==0', {
'defines': ['NO_TCMALLOC'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698