Fixed the crash in the wbaudio source provider when the audio track is going away.

Fixed the crash in the webaudio source provider when the audio track is going away.

Before this CL, it will hit a use-after-free crash on the renderer when the audio track in the media stream is going away and the webaudio mediastreamsourcenode is still running.

BUG=322554
TEST=down upload webaudio.html in issue/322554, run chrome --js-flags=--expose-gc webaudio.html, the renderer should not crash

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162692

[no longer working on chromium, 2013-11-25 10:34:37]

Tommy, could you please review this CL?
Thanks,

SX

[Tommy Widenflycht, 2013-11-25 11:09:32]

Adding Jochen as reviewer since I am not an owner in the directory.

https://codereview.chromium.org/85523002/diff/1/Source/modules/webaudio/Media...
File Source/modules/webaudio/MediaStreamAudioSourceNode.h (right):

https://codereview.chromium.org/85523002/diff/1/Source/modules/webaudio/Media...
Source/modules/webaudio/MediaStreamAudioSourceNode.h:67: // Keep a reference of
the audio MediaStreamTrack which owns the AudioSourceProvider.
NIT: Drop the comment, please

[no longer working on chromium, 2013-11-25 14:00:18]

https://codereview.chromium.org/85523002/diff/1/Source/modules/webaudio/Media...
File Source/modules/webaudio/MediaStreamAudioSourceNode.h (right):

https://codereview.chromium.org/85523002/diff/1/Source/modules/webaudio/Media...
Source/modules/webaudio/MediaStreamAudioSourceNode.h:67: // Keep a reference of
the audio MediaStreamTrack which owns the AudioSourceProvider.
On 2013/11/25 11:09:33, Tommy Widenflycht wrote:
> NIT: Drop the comment, please

Done.

[no longer working on chromium, 2013-11-25 14:00:39]

Thanks Tommy, Jochen, can I have your owner stamp?

BR,
SX

[jochen (gone - plz use gerrit), 2013-11-25 15:49:11]

is it possible to turn the webaudio.html into a layout test?

[Tommy Widenflycht, 2013-11-26 12:35:57]

On 2013/11/25 15:49:11, jochen wrote:
> is it possible to turn the webaudio.html into a layout test?

I just gave this a try and unfortunately this bug doesn't trigger in
content_shell so not much use adding a test...

[no longer working on chromium, 2013-11-26 12:50:53]

On 2013/11/26 12:35:57, Tommy Widenflycht wrote:
> On 2013/11/25 15:49:11, jochen wrote:
> > is it possible to turn the webaudio.html into a layout test?
> 
> I just gave this a try and unfortunately this bug doesn't trigger in
> content_shell so not much use adding a test...

Thanks Tommy.

Jochen, is it possible to land this fix first.

After blink is rolled, I can add a browser test to chrome.

[jochen (gone - plz use gerrit), 2013-11-26 13:25:56]

ok, lgtm

please make sure the browser test gets actually added :)

[commit-bot: I haz the power, 2013-11-26 13:28:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xians@chromium.org/85523002/60001

[no longer working on chromium, 2013-11-26 13:29:01]

On 2013/11/26 13:25:56, jochen wrote:
> ok, lgtm
> 

Thanks.

> please make sure the browser test gets actually added :)

Sure.

[commit-bot: I haz the power, 2013-11-26 15:00:36]

Change committed as 162692