Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3713)

Unified Diff: sky/engine/core/page/EventHandler.cpp

Issue 855223002: Remove unused hit testing modes in Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/rendering/HitTestRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/page/EventHandler.cpp
diff --git a/sky/engine/core/page/EventHandler.cpp b/sky/engine/core/page/EventHandler.cpp
index a5f3a256f5c81094f42197b58ca453f863fd87e6..9e2d8e7db2502e26cd460dcb26eb79b192714fea 100644
--- a/sky/engine/core/page/EventHandler.cpp
+++ b/sky/engine/core/page/EventHandler.cpp
@@ -716,7 +716,7 @@ HitTestResult EventHandler::hitTestResultAtPoint(const LayoutPoint& point, HitTe
return result;
// hitTestResultAtPoint is specifically used to hitTest into all frames, thus it always allows child frame content.
- HitTestRequest request(hitType | HitTestRequest::AllowChildFrameContent);
+ HitTestRequest request(hitType);
m_frame->contentRenderer()->hitTest(request, result);
if (!request.readOnly())
m_frame->document()->updateHoverActiveState(request, result.innerElement());
@@ -1898,7 +1898,7 @@ GestureEventWithHitTestResults EventHandler::targetGestureEvent(const PlatformGe
// Now apply hover/active state to the final target.
// FIXME: This is supposed to send mouseenter/mouseleave events, but doesn't because we
// aren't passing a PlatformMouseEvent.
- HitTestRequest request(hitType | HitTestRequest::AllowChildFrameContent);
+ HitTestRequest request(hitType);
if (!request.readOnly())
m_frame->document()->updateHoverActiveState(request, hitTestResult.innerElement());
@@ -1912,7 +1912,7 @@ GestureEventWithHitTestResults EventHandler::targetGestureEvent(const PlatformGe
HitTestRequest::HitTestRequestType EventHandler::getHitTypeForGestureType(PlatformEvent::Type type)
{
- HitTestRequest::HitTestRequestType hitType = HitTestRequest::TouchEvent | HitTestRequest::AllowFrameScrollbars;
+ HitTestRequest::HitTestRequestType hitType = HitTestRequest::TouchEvent;
switch (type) {
case PlatformEvent::GestureShowPress:
case PlatformEvent::GestureTapUnconfirmed:
« no previous file with comments | « no previous file | sky/engine/core/rendering/HitTestRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698