Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 855043003: Revert "Content handler for python." (Closed)

Created:
5 years, 11 months ago by etiennej
Modified:
5 years, 11 months ago
Reviewers:
jamesr, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Content handler for python." The CL breaks the release linux builds (but not the debug builds). R=qsr@chromium.org, jamesr, qsr BUG= Committed: https://chromium.googlesource.com/external/mojo/+/de68396a25ef4c3669adb631a44d152efad6a486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -790 lines) Patch
M examples/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D examples/python/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D examples/python/__mojo__.py View 1 chunk +0 lines, -63 lines 0 comments Download
M mojo/public/python/BUILD.gn View 2 chunks +0 lines, -12 lines 0 comments Download
M mojo/public/python/mojo_bindings/reflection.py View 5 chunks +7 lines, -16 lines 0 comments Download
D mojo/public/python/rules.gni View 1 chunk +0 lines, -112 lines 0 comments Download
M mojo/public/python/src/common.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/python/src/common.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_python_generator.py View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 3 chunks +0 lines, -45 lines 0 comments Download
D mojo/public/tools/gn/zip.py View 1 chunk +0 lines, -54 lines 0 comments Download
M mojo/python/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/python/content_handler/BUILD.gn View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/python/content_handler/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/python/content_handler/c_base.pxd View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/python/content_handler/content_handler_main.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D mojo/python/content_handler/mojo_system_impl.pyx View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/python/content_handler/python_system_impl_helper.h View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/python/content_handler/python_system_impl_helper.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M mojo/tools/data/apptests View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
etiennej
5 years, 11 months ago (2015-01-16 19:14:17 UTC) #1
qsr
LGTM, feel free to TBR those.
5 years, 11 months ago (2015-01-16 19:14:50 UTC) #2
etiennej
5 years, 11 months ago (2015-01-16 19:19:47 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
de68396a25ef4c3669adb631a44d152efad6a486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698