Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 855033002: command_buffer: Table based command dispatch for Common commands (Closed)

Created:
5 years, 11 months ago by hj.r.chung
Modified:
5 years, 11 months ago
Reviewers:
vmiura, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command_buffer: Table based command dispatch for Common commands Change command dispatch from "switch" based to table based as done with GLES2 Commands. This will probably show marginal performance enhancement but will also raise code consistency. BUG=394570 Committed: https://crrev.com/9249663e8624a36d95d80d24325f225a2e2c953c Cr-Commit-Position: refs/heads/master@{#312780}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -46 lines) Patch
M gpu/command_buffer/service/common_decoder.h View 2 chunks +17 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/common_decoder.cc View 1 8 chunks +34 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hj.r.chung
On 2015/01/19 07:05:33, hj.r.chung wrote: > mailto:heejin.r.chung@samsung.com changed reviewers: > + mailto:piman@chromium.org, mailto:vmiura@chromium.org ptal!
5 years, 11 months ago (2015-01-19 07:07:13 UTC) #2
vmiura
lgtm
5 years, 11 months ago (2015-01-23 03:22:18 UTC) #3
hj.r.chung
On 2015/01/23 03:22:18, vmiura wrote: > lgtm thanks!
5 years, 11 months ago (2015-01-23 04:48:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855033002/20001
5 years, 11 months ago (2015-01-23 04:49:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 05:42:27 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 05:43:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9249663e8624a36d95d80d24325f225a2e2c953c
Cr-Commit-Position: refs/heads/master@{#312780}

Powered by Google App Engine
This is Rietveld 408576698