Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 855023002: Sync the DOMParser interface with spec (Closed)

Created:
5 years, 11 months ago by philipj_slow
Modified:
5 years, 11 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, arv+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 2

Patch Set 3 : revert TypeChecking=Interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M LayoutTests/fast/dom/domparser-parsefromstring-mimetype-support-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/xml/DOMParser.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/xml/DOMParser.cpp View 1 chunk +2 lines, -13 lines 0 comments Download
M Source/core/xml/DOMParser.idl View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
philipj_slow
fix test
5 years, 11 months ago (2015-01-16 15:06:34 UTC) #1
philipj_slow
PTAL
5 years, 11 months ago (2015-01-16 15:06:55 UTC) #3
Jens Widell
LGTM https://codereview.chromium.org/855023002/diff/20001/Source/core/xml/DOMParser.idl File Source/core/xml/DOMParser.idl (right): https://codereview.chromium.org/855023002/diff/20001/Source/core/xml/DOMParser.idl#newcode32 Source/core/xml/DOMParser.idl:32: TypeChecking=Interface, [TypeChecking=Interface] will have no effect since there ...
5 years, 11 months ago (2015-01-16 15:10:46 UTC) #4
philipj_slow
https://codereview.chromium.org/855023002/diff/20001/Source/core/xml/DOMParser.idl File Source/core/xml/DOMParser.idl (right): https://codereview.chromium.org/855023002/diff/20001/Source/core/xml/DOMParser.idl#newcode32 Source/core/xml/DOMParser.idl:32: TypeChecking=Interface, On 2015/01/16 15:10:45, Jens Widell wrote: > [TypeChecking=Interface] ...
5 years, 11 months ago (2015-01-16 19:20:07 UTC) #5
philipj_slow
revert TypeChecking=Interface
5 years, 11 months ago (2015-01-17 00:02:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855023002/40001
5 years, 11 months ago (2015-01-17 00:03:04 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-17 01:20:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188568

Powered by Google App Engine
This is Rietveld 408576698