Log signal strategy progress to server.

remoting/webapp/crd/js/log_to_server.js

Index: remoting/webapp/crd/js/log_to_server.js
diff --git a/remoting/webapp/crd/js/log_to_server.js b/remoting/webapp/crd/js/log_to_server.js
index 4668642be51212b9173b8f3e9f2b5616d47c8317..5b4fb8c02030c40a50db72526b4e0e619a6dc8ed 100644
--- a/remoting/webapp/crd/js/log_to_server.js
+++ b/remoting/webapp/crd/js/log_to_server.js
@@ -32,6 +32,9 @@ remoting.LogToServer = function(signalStrategy, mode) {
   this.mode_ = mode;
   /** @type {string} @private */
   this.connectionType_ = '';
+
+  this.setSessionId_();
+  signalStrategy.sendConnectionSetupResults(this);
 };
 
 // Constants used for generating a session ID.
@@ -56,12 +59,9 @@ remoting.LogToServer.CONNECTION_STATS_ACCUMULATE_TIME = 60 * 1000;
  */
 remoting.LogToServer.prototype.logClientSessionStateChange =
     function(state, connectionError) {
-  this.maybeExpireSessionId();
-  // Maybe set the session ID and start time.
-  if (remoting.LogToServer.isStartOfSession(state)) {
-    if (this.sessionId_ == '') {
-      this.setSessionId();
-    }
+  this.maybeExpireSessionId_();
+  // Set the session start time if we haven't done so already.
+  if (remoting.LogToServer.isStartOfSession_(state)) {
     if (this.sessionStartTime_ == 0) {
       this.sessionStartTime_ = new Date().getTime();
     }
@@ -74,21 +74,21 @@ remoting.LogToServer.prototype.logClientSessionStateChange =
   entry.addWebappVersionField();
   entry.addSessionIdField(this.sessionId_);
   // Maybe clear the session start time, and log the session duration.
-  if (remoting.LogToServer.shouldAddDuration(state) &&
+  if (remoting.LogToServer.shouldAddDuration_(state) &&
       (this.sessionStartTime_ != 0)) {
     entry.addSessionDurationField(
         (new Date().getTime() - this.sessionStartTime_) / 1000.0);
-    if (remoting.LogToServer.isEndOfSession(state)) {
+    if (remoting.LogToServer.isEndOfSession_(state)) {
       this.sessionStartTime_ = 0;
     }
   }
-  this.log(entry);
+  this.log_(entry);
   // Don't accumulate connection statistics across state changes.
-  this.logAccumulatedStatistics();
+  this.logAccumulatedStatistics_();
   this.statsAccumulator_.empty();
   // Maybe clear the session ID.
-  if (remoting.LogToServer.isEndOfSession(state)) {
-    this.clearSessionId();
+  if (remoting.LogToServer.isEndOfSession_(state)) {
+    this.clearSessionId_();
   }
 };
 
@@ -102,6 +102,19 @@ remoting.LogToServer.prototype.setConnectionType = function(connectionType) {
 };
 
 /**
+ * @param {remoting.SignalStrategy.Type} strategyType
+ * @param {remoting.FallbackSignalStrategy.Progress} progress
+ * @param {number} elapsedTimeInMs
+ */
+remoting.LogToServer.prototype.logSignalStrategyProgress =
+    function(strategyType, progress, elapsedTimeInMs) {
+  this.maybeExpireSessionId_();
+  var entry = remoting.ServerLogEntry.makeSignalStrategyProgress(
+      this.sessionId_, strategyType, progress, elapsedTimeInMs);
+  this.log_(entry);
+};
+
+/**
  * Whether a session state is one of the states that occurs at the start of
  * a session.
  *
@@ -109,7 +122,7 @@ remoting.LogToServer.prototype.setConnectionType = function(connectionType) {
  * @param {remoting.ClientSession.State} state
  * @return {boolean}
  */
-remoting.LogToServer.isStartOfSession = function(state) {
+remoting.LogToServer.isStartOfSession_ = function(state) {
   return ((state == remoting.ClientSession.State.CONNECTING) ||
       (state == remoting.ClientSession.State.INITIALIZING) ||
       (state == remoting.ClientSession.State.CONNECTED));
@@ -123,7 +136,7 @@ remoting.LogToServer.isStartOfSession = function(state) {
  * @param {remoting.ClientSession.State} state
  * @return {boolean}
  */
-remoting.LogToServer.isEndOfSession = function(state) {
+remoting.LogToServer.isEndOfSession_ = function(state) {
   return ((state == remoting.ClientSession.State.CLOSED) ||
       (state == remoting.ClientSession.State.FAILED) ||
       (state == remoting.ClientSession.State.CONNECTION_DROPPED) ||
@@ -137,11 +150,11 @@ remoting.LogToServer.isEndOfSession = function(state) {
  * @param {remoting.ClientSession.State} state
  * @return {boolean}
  */
-remoting.LogToServer.shouldAddDuration = function(state) {
+remoting.LogToServer.shouldAddDuration_ = function(state) {
   // Duration is added to log entries at the end of the session, as well as at
   // some intermediate states where it is relevant (e.g. to determine how long
   // it took for a session to become CONNECTED).
-  return (remoting.LogToServer.isEndOfSession(state) ||
+  return (remoting.LogToServer.isEndOfSession_(state) ||
       (state == remoting.ClientSession.State.CONNECTED));
 };
 
@@ -150,14 +163,14 @@ remoting.LogToServer.shouldAddDuration = function(state) {
  * @param {Object.<string, number>} stats The connection statistics
  */
 remoting.LogToServer.prototype.logStatistics = function(stats) {
-  this.maybeExpireSessionId();
+  this.maybeExpireSessionId_();
   // Store the statistics.
   this.statsAccumulator_.add(stats);
   // Send statistics to the server if they've been accumulating for at least
   // 60 seconds.
   if (this.statsAccumulator_.getTimeSinceFirstValue() >=
       remoting.LogToServer.CONNECTION_STATS_ACCUMULATE_TIME) {
-    this.logAccumulatedStatistics();
+    this.logAccumulatedStatistics_();
   }
 };
 
@@ -169,7 +182,7 @@ remoting.LogToServer.prototype.logStatistics = function(stats) {
  *
  * @private
  */
-remoting.LogToServer.prototype.logAccumulatedStatistics = function() {
+remoting.LogToServer.prototype.logAccumulatedStatistics_ = function() {
   var entry = remoting.ServerLogEntry.makeStats(this.statsAccumulator_,
                                                 this.connectionType_,
                                                 this.mode_);
@@ -178,7 +191,7 @@ remoting.LogToServer.prototype.logAccumulatedStatistics = function() {
     entry.addChromeVersionField();
     entry.addWebappVersionField();
     entry.addSessionIdField(this.sessionId_);
-    this.log(entry);
+    this.log_(entry);
   }
   this.statsAccumulator_.empty();
 };
@@ -189,7 +202,7 @@ remoting.LogToServer.prototype.logAccumulatedStatistics = function() {
  * @private
  * @param {remoting.ServerLogEntry} entry
  */
-remoting.LogToServer.prototype.log = function(entry) {
+remoting.LogToServer.prototype.log_ = function(entry) {
   // Send the stanza to the debug log.
   console.log('Enqueueing log entry:');
   entry.toDebugLog(1);
@@ -208,8 +221,8 @@ remoting.LogToServer.prototype.log = function(entry) {
  *
  * @private
  */
-remoting.LogToServer.prototype.setSessionId = function() {
-  this.sessionId_ = remoting.LogToServer.generateSessionId();
+remoting.LogToServer.prototype.setSessionId_ = function() {
+  this.sessionId_ = remoting.LogToServer.generateSessionId_();
   this.sessionIdGenerationTime_ = new Date().getTime();
 };
 
@@ -218,7 +231,7 @@ remoting.LogToServer.prototype.setSessionId = function() {
  *
  * @private
  */
-remoting.LogToServer.prototype.clearSessionId = function() {
+remoting.LogToServer.prototype.clearSessionId_ = function() {
   this.sessionId_ = '';
   this.sessionIdGenerationTime_ = 0;
 };
@@ -231,20 +244,20 @@ remoting.LogToServer.prototype.clearSessionId = function() {
  *
  * @private
  */
-remoting.LogToServer.prototype.maybeExpireSessionId = function() {
+remoting.LogToServer.prototype.maybeExpireSessionId_ = function() {
   if ((this.sessionId_ != '') &&
       (new Date().getTime() - this.sessionIdGenerationTime_ >=
       remoting.LogToServer.MAX_SESSION_ID_AGE)) {
     // Log the old session ID.
     var entry = remoting.ServerLogEntry.makeSessionIdOld(this.sessionId_,
                                                          this.mode_);
-    this.log(entry);
+    this.log_(entry);
     // Generate a new session ID.
-    this.setSessionId();
+    this.setSessionId_();
     // Log the new session ID.
     entry = remoting.ServerLogEntry.makeSessionIdNew(this.sessionId_,
                                                      this.mode_);
-    this.log(entry);
+    this.log_(entry);
   }
 };
 
@@ -254,7 +267,7 @@ remoting.LogToServer.prototype.maybeExpireSessionId = function() {
  * @private
  * @return {string} a session ID
  */
-remoting.LogToServer.generateSessionId = function() {
+remoting.LogToServer.generateSessionId_ = function() {
   var idArray = [];
   for (var i = 0; i < remoting.LogToServer.SESSION_ID_LEN_; i++) {
     var index =