Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: remoting/webapp/crd/js/signal_strategy.js

Issue 855003008: Log signal strategy progress to server. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update for new log format. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/server_log_entry.js ('k') | remoting/webapp/crd/js/wcs_adapter.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/signal_strategy.js
diff --git a/remoting/webapp/crd/js/signal_strategy.js b/remoting/webapp/crd/js/signal_strategy.js
index f07613f9bd3a71175197341e38896592fce4788f..8d1f57830b6cf32a172ea7204648a3898aab6cbf 100644
--- a/remoting/webapp/crd/js/signal_strategy.js
+++ b/remoting/webapp/crd/js/signal_strategy.js
@@ -35,6 +35,15 @@ remoting.SignalStrategy.State = {
CLOSED: 5
};
+/**
+ * @enum {string} SignalStrategy types. Do not add to these values without
+ * updating the corresponding enum in chromoting_extensions.proto.
+ */
+remoting.SignalStrategy.Type = {
+ XMPP: 'xmpp',
+ WCS: 'wcs'
+};
+
remoting.SignalStrategy.prototype.dispose = function() {};
/**
@@ -59,6 +68,16 @@ remoting.SignalStrategy.prototype.connect =
*/
remoting.SignalStrategy.prototype.sendMessage = function(message) {};
+/**
+ * Send any messages accumulated during connection set-up.
+ *
+ * @param {remoting.LogToServer} logToServer The LogToServer instance for the
+ * connection.
+ */
+remoting.SignalStrategy.prototype.sendConnectionSetupResults =
+ function(logToServer) {
+};
+
/** @return {remoting.SignalStrategy.State} Current state */
remoting.SignalStrategy.prototype.getState = function() {};
@@ -68,6 +87,9 @@ remoting.SignalStrategy.prototype.getError = function() {};
/** @return {string} Current JID when in CONNECTED state. */
remoting.SignalStrategy.prototype.getJid = function() {};
+/** @return {remoting.SignalStrategy.Type} The signal strategy type. */
+remoting.SignalStrategy.prototype.getType = function() {};
Jamie 2015/01/21 19:41:08 I'm not crazy about this design, since it means th
+
/**
* Creates the appropriate signal strategy for the current environment.
* @param {function(remoting.SignalStrategy.State): void} onStateChangedCallback
@@ -92,15 +114,8 @@ remoting.SignalStrategy.create = function(onStateChangedCallback) {
return new remoting.WcsAdapter(onStateChanged);
};
- /**
- * @param {remoting.FallbackSignalStrategy.Progress} progress
- */
- var progressCallback = function(progress) {
- console.log('FallbackSignalStrategy progress: ' + progress);
- };
-
return new remoting.FallbackSignalStrategy(
- xmppFactory, wcsFactory, onStateChangedCallback, progressCallback);
+ xmppFactory, wcsFactory, onStateChangedCallback);
} else {
return new remoting.WcsAdapter(onStateChangedCallback);
« no previous file with comments | « remoting/webapp/crd/js/server_log_entry.js ('k') | remoting/webapp/crd/js/wcs_adapter.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698