Log signal strategy progress to server.

remoting/webapp/crd/js/signal_strategy.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 17 matching lines @@
  */
 remoting.SignalStrategy.State = {
   NOT_CONNECTED: 0,
   CONNECTING: 1,
   HANDSHAKE: 2,
   CONNECTED: 3,
   FAILED: 4,
   CLOSED: 5
 };
 
+/**
+ * @enum {string} SignalStrategy types. Do not add to these values without
+ *     updating the corresponding enum in chromoting_extensions.proto.
+ */
+remoting.SignalStrategy.Type = {
+  XMPP: 'xmpp',
+  WCS: 'wcs'
+};
+
 remoting.SignalStrategy.prototype.dispose = function() {};
 
 /**
  * @param {?function(Element):void} onIncomingStanzaCallback Callback to call on
  *     incoming messages.
  */
 remoting.SignalStrategy.prototype.setIncomingStanzaCallback =
     function(onIncomingStanzaCallback) {};
 
 /**
  * @param {string} server
  * @param {string} username
  * @param {string} authToken
  */
 remoting.SignalStrategy.prototype.connect =
     function(server, username, authToken) {
 };
 
 /**
  * Sends a message. Can be called only in CONNECTED state.
  * @param {string} message
  */
 remoting.SignalStrategy.prototype.sendMessage = function(message) {};
 
+/**
+ * Send any messages accumulated during connection set-up.
+ *
+ * @param {remoting.LogToServer} logToServer The LogToServer instance for the
+ *     connection.
+ */
+remoting.SignalStrategy.prototype.sendConnectionSetupResults =
+    function(logToServer) {
+};
+
 /** @return {remoting.SignalStrategy.State} Current state */
 remoting.SignalStrategy.prototype.getState = function() {};
 
 /** @return {remoting.Error} Error when in FAILED state. */
 remoting.SignalStrategy.prototype.getError = function() {};
 
 /** @return {string} Current JID when in CONNECTED state. */
 remoting.SignalStrategy.prototype.getJid = function() {};
 
+/** @return {remoting.SignalStrategy.Type} The signal strategy type. */
+remoting.SignalStrategy.prototype.getType = function() {};

[Jamie, 2015/01/21 19:41:08]

I'm not crazy about this design, since it means that the base class effectively
needs to know about all (non-test) subclasses, but I don't see a cleaner
alternative that satisfies your logging suggestions (which I agree with).

+
 /**
  * Creates the appropriate signal strategy for the current environment.
  * @param {function(remoting.SignalStrategy.State): void} onStateChangedCallback
  * @return {remoting.SignalStrategy} New signal strategy object.
  */
 remoting.SignalStrategy.create = function(onStateChangedCallback) {
   // Only use XMPP when TCP API is available and TLS support is enabled. That's
   // not the case for V1 app (socket API is available only to platform apps)
   // and for Chrome releases before 38.
   if (chrome.socket && chrome.socket.secure) {
     /**
      * @param {function(remoting.SignalStrategy.State): void} onStateChanged
      */
     var xmppFactory = function(onStateChanged) {
       return new remoting.XmppConnection(onStateChanged);
     };
 
     /**
      * @param {function(remoting.SignalStrategy.State): void} onStateChanged
      */
     var wcsFactory = function(onStateChanged) {
       return new remoting.WcsAdapter(onStateChanged);
     };
 
-    /**
-     * @param {remoting.FallbackSignalStrategy.Progress} progress
-     */
-    var progressCallback = function(progress) {
-      console.log('FallbackSignalStrategy progress: ' + progress);
-    };
-
     return new remoting.FallbackSignalStrategy(
-        xmppFactory, wcsFactory, onStateChangedCallback, progressCallback);
+        xmppFactory, wcsFactory, onStateChangedCallback);
 
   } else {
     return new remoting.WcsAdapter(onStateChangedCallback);
   }
 };