Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: sky/engine/core/rendering/FilterEffectRenderer.cpp

Issue 854963002: Removed unused paintInvalidationRect member. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/FilterEffectRenderer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/FilterEffectRenderer.cpp
diff --git a/sky/engine/core/rendering/FilterEffectRenderer.cpp b/sky/engine/core/rendering/FilterEffectRenderer.cpp
index 18408ab20a4925d3a955ddcb9e102e5f013e7b49..f8635c9d59cd135f7cb54e898283de0ec5900255 100644
--- a/sky/engine/core/rendering/FilterEffectRenderer.cpp
+++ b/sky/engine/core/rendering/FilterEffectRenderer.cpp
@@ -241,17 +241,16 @@ bool FilterEffectRenderer::build(RenderObject* renderer, const FilterOperations&
return true;
}
-bool FilterEffectRenderer::updateBackingStoreRect(const FloatRect& floatFilterRect)
+void FilterEffectRenderer::updateBackingStoreRect(const FloatRect& floatFilterRect)
{
IntRect filterRect = enclosingIntRect(floatFilterRect);
if (!filterRect.isEmpty() && FilterEffect::isFilterSizeValid(filterRect)) {
FloatRect currentSourceRect = sourceImageRect();
if (filterRect != currentSourceRect) {
setSourceImageRect(filterRect);
- return true;
+ return;
}
}
- return false;
}
void FilterEffectRenderer::allocateBackingStoreIfNeeded()
@@ -297,7 +296,6 @@ bool FilterEffectRendererHelper::prepareFilterEffect(RenderLayer* renderLayer, c
{
ASSERT(m_haveFilterEffect && renderLayer->filterRenderer());
m_renderLayer = renderLayer;
- m_paintInvalidationRect = dirtyRect;
// Prepare a transformation that brings the coordinates into the space
// filter coordinates are defined in.
@@ -320,13 +318,7 @@ bool FilterEffectRendererHelper::prepareFilterEffect(RenderLayer* renderLayer, c
filter->setFilterRegion(filter->mapAbsoluteRectToLocalRect(filterSourceRect));
filter->lastEffect()->determineFilterPrimitiveSubregion(MapRectForward);
- bool hasUpdatedBackingStore = filter->updateBackingStoreRect(filterSourceRect);
- if (filter->hasFilterThatMovesPixels()) {
- if (hasUpdatedBackingStore)
- m_paintInvalidationRect = filterSourceRect;
- else
- m_paintInvalidationRect.intersect(filterSourceRect);
- }
+ filter->updateBackingStoreRect(filterSourceRect);
return true;
}
« no previous file with comments | « sky/engine/core/rendering/FilterEffectRenderer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698