Remove RenderViewObserver::Resized (try 2)

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
@@ skipping 137 matching lines @@
 IPC_MESSAGE_ROUTED0(AutofillMsg_ClearPreviewedForm)
 
 // Sets the currently selected node's value.
 IPC_MESSAGE_ROUTED1(AutofillMsg_FillFieldWithValue,
                     base::string16 /* value */)
 
 // Sets the suggested value for the currently previewed node.
 IPC_MESSAGE_ROUTED1(AutofillMsg_PreviewFieldWithValue,
                     base::string16 /* value */)
 
+// The popup has been hidden.
+IPC_MESSAGE_ROUTED0(AutofillMsg_PopupHidden);

[Avi (use Gerrit), 2015/01/16 20:01:45]

Was hidden, or should be hidden?

[Evan Stade, 2015/01/16 20:29:14]

Was hidden. "Should be hidden" would be "HidePopup".

Not sure if this comment was a request to change the message name, but if so,
it's an established pattern that past participle indicates notification of an
action that already happened. See AccountCreationFormsDetected,
FirstUserGestureObserved, FormSeen, etc.

[Avi (use Gerrit), 2015/01/16 20:35:12]

I got that. I misunderstood the code flow, and thought that this was a request
to the renderer to do the hiding rather than a notification that it had been
done.

+
 // Sets the currently selected node's value to be the given data list value.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptDataListSuggestion,
                     base::string16 /* accepted data list value */)
 
 // Tells the renderer to populate the correct password fields with this
 // generated password.
 IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,
                     base::string16 /* generated_password */)
 
 // Tells the renderer to fill the username and password with with given
@@ skipping 139 matching lines @@
     int /* key */,
     base::i18n::TextDirection /* text_direction */,
     base::string16 /* username typed by user */,
     int /* options bitmask of autofill::ShowPasswordSuggestionsOptions */,
     gfx::RectF /* input field bounds, window-relative */)
 
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)