Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1787)

Issue 854913002: clang/win bots: Don't run content_unittests twice. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, cmp-cc_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

clang/win bots: Don't run content_unittests twice. tests_win_1 already contains 'unit', which expands to tests that include content_unittests already: https://code.google.com/p/chromium/codesearch#chromium/build/scripts/master/factory/chromium_commands.py&l=557 I noticed this because I added "content_unittests_1" to the test list on the new recipes bot, and it complains that this doesn't exist. And, sure enough, on our old non-recipes bots content_unittests_1 runs the same tests that content_unittests runs. BUG=446368 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M masters/master.chromium.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
5 years, 11 months ago (2015-01-15 21:14:01 UTC) #2
Reid Kleckner
lgtm wat
5 years, 11 months ago (2015-01-15 21:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854913002/1
5 years, 11 months ago (2015-01-15 21:21:03 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 21:21:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293656

Powered by Google App Engine
This is Rietveld 408576698