Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: content/browser/debugger/worker_devtools_manager.cc

Issue 8549022: Define DevTools content API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jam's comments addressed Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/worker_devtools_manager.cc
diff --git a/content/browser/debugger/worker_devtools_manager.cc b/content/browser/debugger/worker_devtools_manager.cc
index 6d6b3667e5974df194a2e2c36b29943342ff69c4..6709d7519cfc3a4b624f47f2113016e948a49cfa 100644
--- a/content/browser/debugger/worker_devtools_manager.cc
+++ b/content/browser/debugger/worker_devtools_manager.cc
@@ -9,12 +9,13 @@
#include "base/bind.h"
#include "content/browser/debugger/devtools_agent_host.h"
-#include "content/browser/debugger/devtools_manager.h"
+#include "content/browser/debugger/devtools_manager_impl.h"
#include "content/browser/debugger/worker_devtools_message_filter.h"
#include "content/browser/worker_host/worker_process_host.h"
#include "content/browser/worker_host/worker_service.h"
#include "content/common/devtools_messages.h"
#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/devtools_agent_host_registry.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/notification_service.h"
@@ -26,6 +27,18 @@
using content::BrowserThread;
+namespace content {
+
+// Called on the UI thread.
+// static
+DevToolsAgentHost* DevToolsAgentHostRegistry::GetDevToolsAgentHostForWorker(
+ int worker_process_id,
+ int worker_route_id) {
+ return WorkerDevToolsManager::GetDevToolsAgentHostForWorker(
+ worker_process_id,
+ worker_route_id);
+}
+
class WorkerDevToolsManager::AgentHosts
: private content::NotificationObserver {
public:
@@ -165,10 +178,10 @@ class WorkerDevToolsManager::DetachedClientHosts {
RemovePendingWorkerData(id);
return;
}
- DevToolsManager::GetInstance()->ForwardToDevToolsClient(agent,
- DevToolsClientMsg_DispatchOnInspectorFrontend(MSG_ROUTING_NONE,
- WebKit::WebDevToolsAgent::disconnectEventAsText().utf8()));
- int cookie = DevToolsManager::GetInstance()->DetachClientHost(agent);
+ DevToolsManagerImpl::GetInstance()->DispatchOnInspectorFrontend(
+ agent,
+ WebKit::WebDevToolsAgent::disconnectEventAsText().utf8());
+ int cookie = DevToolsManagerImpl::GetInstance()->DetachClientHost(agent);
if (cookie == -1) {
RemovePendingWorkerData(id);
return;
@@ -194,7 +207,7 @@ class WorkerDevToolsManager::DetachedClientHosts {
WorkerDevToolsManager::GetDevToolsAgentHostForWorker(
new_id.first,
new_id.second);
- DevToolsManager::GetInstance()->AttachClientHost(
+ DevToolsManagerImpl::GetInstance()->AttachClientHost(
it->second,
agent);
worker_id_to_cookie_.erase(it);
@@ -386,7 +399,7 @@ void WorkerDevToolsManager::RegisterDevToolsAgentHostForWorker(
void WorkerDevToolsManager::ForwardToDevToolsClient(
int worker_process_id,
int worker_route_id,
- const IPC::Message& message) {
+ const std::string& message) {
if (FindInspectedWorker(worker_process_id, worker_route_id) ==
inspected_workers_.end()) {
NOTREACHED();
@@ -431,13 +444,14 @@ void WorkerDevToolsManager::ForwardToWorkerDevToolsAgent(
void WorkerDevToolsManager::ForwardToDevToolsClientOnUIThread(
int worker_process_id,
int worker_route_id,
- const IPC::Message& message) {
+ const std::string& message) {
WorkerDevToolsAgentHost* agent_host = AgentHosts::GetAgentHost(WorkerId(
worker_process_id,
worker_route_id));
if (!agent_host)
return;
- DevToolsManager::GetInstance()->ForwardToDevToolsClient(agent_host, message);
+ DevToolsManagerImpl::GetInstance()->DispatchOnInspectorFrontend(agent_host,
+ message);
}
// static
@@ -450,7 +464,7 @@ void WorkerDevToolsManager::SaveAgentRuntimeStateOnUIThread(
worker_route_id));
if (!agent_host)
return;
- DevToolsManager::GetInstance()->SaveAgentRuntimeState(agent_host, state);
+ DevToolsManagerImpl::GetInstance()->SaveAgentRuntimeState(agent_host, state);
}
// static
@@ -480,3 +494,5 @@ void WorkerDevToolsManager::SendResumeToWorker(const WorkerId& id) {
if (WorkerProcessHost* process = FindWorkerProcess(id.first))
process->Send(new DevToolsAgentMsg_ResumeWorkerContext(id.second));
}
+
+} // namespace
« no previous file with comments | « content/browser/debugger/worker_devtools_manager.h ('k') | content/browser/debugger/worker_devtools_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698