Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3851)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 8549022: Define DevTools content API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jam's comments addressed Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 83043b58abe1a5a00a5843ccbbd080dadc7f8361..035e84cc7acaf524af293f8ef6001c33266f5da5 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -32,10 +32,11 @@
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
-#include "content/browser/debugger/devtools_client_host.h"
-#include "content/browser/debugger/devtools_manager.h"
#include "content/browser/renderer_host/render_view_host.h"
#include "content/browser/tab_contents/tab_contents.h"
+#include "content/public/browser/devtools_agent_host_registry.h"
+#include "content/public/browser/devtools_client_host.h"
+#include "content/public/browser/devtools_manager.h"
#include "content/public/browser/notification_service.h"
#include "content/public/common/url_constants.h"
#include "grit/generated_resources.h"
@@ -45,6 +46,10 @@
#include "ui/base/l10n/l10n_util.h"
using content::BrowserThread;
+using content::DevToolsAgentHost;
+using content::DevToolsAgentHostRegistry;
+using content::DevToolsClientHost;
+using content::DevToolsManager;
// Prerender tests work as follows:
//
@@ -395,12 +400,10 @@ class TestSafeBrowsingServiceFactory : public SafeBrowsingServiceFactory {
class FakeDevToolsClientHost : public DevToolsClientHost {
public:
FakeDevToolsClientHost() {}
- virtual ~FakeDevToolsClientHost() {
- NotifyCloseListener();
- }
+ virtual ~FakeDevToolsClientHost() {}
virtual void InspectedTabClosing() OVERRIDE {}
virtual void FrameNavigating(const std::string& url) OVERRIDE {}
- virtual void SendMessageToClient(const IPC::Message& msg) OVERRIDE {}
+ virtual void DispatchOnInspectorFrontend(const std::string& msg) OVERRIDE {}
virtual void TabReplaced(TabContents* new_tab) OVERRIDE {}
};
@@ -1836,13 +1839,15 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
NavigateToPrerenderedPageWhenDevToolsAttached) {
DisableJavascriptCalls();
TabContents* tab_contents = browser()->GetSelectedTabContents();
- RenderViewHost* inspected_rvh = tab_contents->render_view_host();
+ DevToolsAgentHost* agent = DevToolsAgentHostRegistry::GetDevToolsAgentHost(
+ tab_contents->render_view_host());
DevToolsManager* manager = DevToolsManager::GetInstance();
FakeDevToolsClientHost client_host;
- manager->RegisterDevToolsClientHostFor(inspected_rvh, &client_host);
+ manager->RegisterDevToolsClientHostFor(agent, &client_host);
const char* url = "files/prerender/prerender_page.html";
PrerenderTestURL(url, FINAL_STATUS_DEVTOOLS_ATTACHED, 1);
NavigateToURL(url);
+ manager->ClientHostClosing(&client_host);
}
// Validate that the sessionStorage namespace remains the same when swapping
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698