Issue 854883002: win: use FileOffset, not off_t in string_file_writer_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 854883002: win: use FileOffset, not off_t in string_file_writer_test (Closed)

Created:
5 years, 11 months ago by scottmg

Modified:
5 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: use FileOffset, not off_t in string_file_writer_test off_t exists on Windows, but Seek is implemented in terms of SetFilePointerEx which expects a LONGLONG, so FileOffset is LONGLONG. So, use FileOffset in the test code so that it wraps at the expected value. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ac6a7455fde366e0619dac8a5bb04e09042d07dc

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	util/file/string_file_writer_test.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

scottmg

5 years, 11 months ago (2015-01-15 19:24:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ac6a7455fde366e0619dac8a5bb04e09042d07dc (presubmit successful).