Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: LayoutTests/media/track/track-add-remove-cue.html

Issue 854863002: VTTCue: Add TypeChecking=Unrestricted (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/track/track-add-remove-cue.html
diff --git a/LayoutTests/media/track/track-add-remove-cue.html b/LayoutTests/media/track/track-add-remove-cue.html
index a60de24937c95802d0ec79ba1a3854803cba8f66..adf8233aba389f9e80701ca6423b501146207a36 100644
--- a/LayoutTests/media/track/track-add-remove-cue.html
+++ b/LayoutTests/media/track/track-add-remove-cue.html
@@ -65,14 +65,7 @@
testExpected("newCue.align", "middle");
consoleWrite("<br>*** Create an old-style cue with an id.");
- run("oldStyleCue = new VTTCue('sausage-cue', 33, 3.4, 'Sausage?')");
- testExpected("oldStyleCue.id", "");
- testExpected("oldStyleCue.startTime.toString()", "NaN");
- testExpected("oldStyleCue.endTime", 33);
- consoleWrite("*** Make sure the old-style cue is not inserted because its start time is not a number.");
- testExpected("testTrack.track.cues.length", 5);
- run("testTrack.track.addCue(oldStyleCue)");
- testExpected("testTrack.track.cues.length", 5);
+ testException("oldStyleCue = new VTTCue('sausage-cue', 33, 3.4, 'Sausage?')", '"TypeError: Failed to construct \'VTTCue\': double parameter 1 is non-finite."');
philipj_slow 2015/01/19 08:49:36 Drop the 'sausage-cue' arguemnt and s/33/NaN/ to a
fs 2015/01/19 10:18:16 Based on "Create an old-style cue with an id" just
philipj_slow 2015/01/19 10:31:10 Oh, right. Seems like a pretty useless test to kee
fs 2015/01/19 11:42:44 Removed. Description updated.
consoleWrite("<br>*** Remove a cue created with addCue().");
run("testTrack.track.removeCue(textCue)");

Powered by Google App Engine
This is Rietveld 408576698