Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 854833004: Add pprof support to skydb (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add pprof support to skydb After this CL, we're able to capture pprof profiles, but we're not quite able to symbolize them properly. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b737c0531e299ad494725c518699843e76ff84f5

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M sky/tools/debugger/prompt/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/debugger/prompt/prompt.cc View 1 3 chunks +15 lines, -1 line 0 comments Download
M sky/tools/skydb View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-16 00:19:38 UTC) #1
eseidel
lgtm
5 years, 11 months ago (2015-01-16 00:21:57 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-16 00:34:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b737c0531e299ad494725c518699843e76ff84f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698