Issue 8548007: Split html library into html and html_impl

Issue 8548007: Split html library into html and html_impl (Closed)

Created:
9 years, 1 month ago by Jacob

Modified:
9 years ago

Reviewers:
vsm, nweiz, jgw, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Split html library into html and html_impl BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1879

Patch Set 1 : ready to review #

Total comments: 3

Patch Set 2 : Fix one file that was in the wrong library, add frog and dartc support. #

Patch Set 3 : Sync and fix bug in html_tests #

Created: 9 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2605 lines, -20328 lines)			Patch
M	client/html/html.dart	View	1 2	2 chunks	+1 line, -292 lines	0 comments	Download
A +	client/html/htmlimpl.dart	View	1 2	2 chunks	+2 lines, -288 lines	0 comments	Download
M	client/html/release/html.dart	View	1 2	6 chunks	+2596 lines, -19746 lines	0 comments	Download
M	client/tests/client/html/html_tests.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/SystemLibraryManager.java	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/scripts/generate_my_projects.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/frogsh	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/reader.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jacob

I also added a client/html/release/html_impl.dart file but unfortunately it is too large to upload properly.

9 years, 1 month ago (2011-11-22 19:43:17 UTC) #1

vsm

Tentative LGTM, but let me get you a corresponding Dartium CL to pull in the ...

9 years, 1 month ago (2011-11-22 20:35:16 UTC) #2

vsm

LGTM with changes address plus: - Edit frog/reader.dart and add an entry for dart:htmlimpl. - ...

9 years, 1 month ago (2011-11-23 18:01:47 UTC) #4

Jacob

9 years, 1 month ago (2011-11-23 23:10:09 UTC) #5

Added changes required to make this work with Frog and DartC

http://codereview.chromium.org/8548007/diff/9002/client/html/html_impl.dart
File client/html/html_impl.dart (right):

http://codereview.chromium.org/8548007/diff/9002/client/html/html_impl.dart#n...
client/html/html_impl.dart:8: #library('html_impl');
On 2011/11/23 18:01:47, vsm wrote:
> #library('dart:htmlimpl');
> 
> (Consistent with dart:core and dart:coreimpl.)

Done.

Expand Messages | Collapse Messages