Fix font loading in OOP PDF

content/ppapi_plugin/ppapi_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/ppapi_plugin/ppapi_thread.h"
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/cpu.h"
@@ skipping 24 matching lines @@
 #include "ipc/ipc_sync_channel.h"
 #include "ipc/ipc_sync_message_filter.h"
 #include "ppapi/c/dev/ppp_network_state_dev.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/ppp.h"
 #include "ppapi/proxy/interface_list.h"
 #include "ppapi/proxy/plugin_globals.h"
 #include "ppapi/proxy/plugin_message_filter.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/resource_reply_thread_registrar.h"
+#include "ppapi/shared_impl/proxy_lock.h"
 #include "third_party/WebKit/public/web/WebKit.h"
 #include "ui/base/ui_base_switches.h"
 
 #if defined(OS_WIN)
+#include "base/win/iat_patch_function.h"
 #include "base/win/win_util.h"
 #include "base/win/windows_version.h"
 #include "sandbox/win/src/sandbox.h"
 #elif defined(OS_MACOSX)
 #include "content/common/sandbox_init_mac.h"
 #endif
 
 #if defined(OS_WIN)
 const char kWidevineCdmAdapterFileName[] = "widevinecdmadapter.dll";
 
@@ skipping 25 matching lines @@
       PfnEnumSystemLocalesEx enum_sys_locales_ex =
           reinterpret_cast<PfnEnumSystemLocalesEx>
               (GetProcAddress(handle_kern32, "EnumSystemLocalesEx"));
 
       enum_sys_locales_ex(EnumLocalesProcEx, LOCALE_WINDOWS, 0, 0);
     } else {
       EnumSystemLocalesW(EnumLocalesProc, LCID_INSTALLED);
     }
   }
 }
+
+// TODO(scottmg): http://crbug.com/448473. This code should be removed from the
+// renderer once PDF is always OOP and/or PDF is made to use Skia instead of GDI

[ananta, 2015/01/15 02:31:22]

Move the once PDF is always OOP comment portion to the other file.

[scottmg, 2015/01/15 02:35:38]

Done.

+// directly.
+const wchar_t kPdfFileName[] = L"pdf.dll";
+
+static base::win::IATPatchFunction g_iat_patch_createdca;
+HDC WINAPI CreateDCAPatch(LPCSTR driver_name,
+                          LPCSTR device_name,
+                          LPCSTR output,
+                          const void* init_data) {
+  DCHECK(std::string("DISPLAY") == std::string(driver_name));
+  DCHECK(!device_name);
+  DCHECK(!output);
+  DCHECK(!init_data);
+
+  // CreateDC fails behind the sandbox, but not CreateCompatibleDC.
+  return CreateCompatibleDC(NULL);
+}
+
+static base::win::IATPatchFunction g_iat_patch_get_font_data;
+DWORD WINAPI GetFontDataPatch(HDC hdc,
+                              DWORD table,
+                              DWORD offset,
+                              LPVOID buffer,
+                              DWORD length) {
+  int rv = GetFontData(hdc, table, offset, buffer, length);
+  if (rv == GDI_ERROR && hdc) {
+    HFONT font = static_cast<HFONT>(GetCurrentObject(hdc, OBJ_FONT));
+
+    LOGFONT logfont;
+    if (GetObject(font, sizeof(LOGFONT), &logfont)) {
+      std::vector<char> font_data;
+      {
+        ppapi::ProxyAutoLock lock;
+        ppapi::proxy::PluginGlobals::Get()->PreCacheFontForFlash(
+            reinterpret_cast<const void*>(&logfont));
+      }
+      rv = GetFontData(hdc, table, offset, buffer, length);
+    }
+  }
+  return rv;
+}
+
 #else
 extern void* g_target_services;
 #endif
 
 namespace content {
 
 typedef int32_t (*InitializeBrokerFunc)
     (PP_ConnectInstance_Func* connect_instance_func);
 
 PpapiThread::PpapiThread(const base::CommandLine& command_line, bool is_broker)
@@ skipping 214 matching lines @@
         return;
       }
     }
   }
 
 #if defined(OS_WIN)
   // If code subsequently tries to exit using abort(), force a crash (since
   // otherwise these would be silent terminations and fly under the radar).
   base::win::SetAbortBehaviorForCrashReporting();
 
+  // Need to patch a few functions for font loading to work correctly. This can
+  // be removed once we switch PDF to use Skia.

[ananta, 2015/01/15 02:31:22]

Some commentary which explains this voodoo to get fonts to work would be
helpful. 

[scottmg, 2015/01/15 02:35:38]

Done, above at the PreCache...  call.

+  if (GetModuleHandle(kPdfFileName)) {
+    g_iat_patch_createdca.Patch(kPdfFileName, "gdi32.dll", "CreateDCA",
+                                CreateDCAPatch);
+    g_iat_patch_get_font_data.Patch(kPdfFileName, "gdi32.dll", "GetFontData",
+                                    GetFontDataPatch);
+  }
+
   // Once we lower the token the sandbox is locked down and no new modules
   // can be loaded. TODO(cpu): consider changing to the loading style of
   // regular plugins.
   if (g_target_services) {
     // Let Flash and Widevine CDM adapter load DXVA before lockdown on Vista+.
     if (permissions.HasPermission(ppapi::PERMISSION_FLASH) ||
         path.BaseName().MaybeAsASCII() == kWidevineCdmAdapterFileName) {
       if (base::win::OSInfo::GetInstance()->version() >=
           base::win::VERSION_VISTA) {
         LoadLibraryA("dxva2.dll");
@@ skipping 204 matching lines @@
       std::string("Plugin.Ppapi") + (is_broker_ ? "Broker" : "Plugin") +
       "LoadErrorCode_" + path.BaseName().MaybeAsASCII();
 
   // For sparse histograms, we can use the macro, as it does not incorporate a
   // static.
   UMA_HISTOGRAM_SPARSE_SLOWLY(histogram_name, error.code);
 #endif
 }
 
 }  // namespace content