Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/ui/libgtk2ui/libgtk2ui.gyp

Issue 854753002: linux/gyp: Find missing symbols at build time, not runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/libgtk2ui/libgtk2ui.gyp
diff --git a/chrome/browser/ui/libgtk2ui/libgtk2ui.gyp b/chrome/browser/ui/libgtk2ui/libgtk2ui.gyp
index d66b00c48ef1c6d2af58470a5ea2a1d29f395805..4145f6776221d0b4e70ad979579dacc33e1587be 100644
--- a/chrome/browser/ui/libgtk2ui/libgtk2ui.gyp
+++ b/chrome/browser/ui/libgtk2ui/libgtk2ui.gyp
@@ -19,10 +19,19 @@
'../../../../build/linux/system.gyp:gtk',
'../../../../build/linux/system.gyp:gtkprint',
'../../../../components/components_resources.gyp:components_resources',
+ '../../../../content/content.gyp:content',
'../../../../printing/printing.gyp:cups',
+ '../../../../printing/printing.gyp:printing',
'../../../../skia/skia.gyp:skia',
+ '../../../../ui/aura/aura.gyp:aura',
'../../../../ui/base/ui_base.gyp:ui_base',
+ '../../../../ui/events/events.gyp:events',
+ '../../../../ui/events/events.gyp:events_base',
+ '../../../../ui/gfx/gfx.gyp:gfx',
+ '../../../../ui/gfx/x/gfx_x11.gyp:gfx_x11',
+ '../../../../ui/native_theme/native_theme.gyp:native_theme',
'../../../../ui/resources/ui_resources.gyp:ui_resources',
+ '../../../../ui/shell_dialogs/shell_dialogs.gyp:shell_dialogs',
'../../../../ui/strings/ui_strings.gyp:ui_strings',
'../../../../ui/views/views.gyp:views',
'../../../chrome_resources.gyp:chrome_extra_resources',
@@ -88,6 +97,7 @@
'x11_input_method_context_impl_gtk2.cc',
'x11_input_method_context_impl_gtk2.h',
],
+ 'link_settings': { 'libraries': [ '-lX11' ] },
jamesr 2015/01/17 01:21:25 hmm, is there a reason you use link_settings here
Nico 2015/01/17 02:01:43 No. I looked at https://code.google.com/p/chromium
'conditions': [
['use_gconf==0', {
'sources!': [
« no previous file with comments | « build/common.gypi ('k') | content/content_browser.gypi » ('j') | content/content_shell.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698