linux/gyp: Find missing symbols at build time, not runtime.

linux/gyp: Find missing symbols at build time, not runtime.

Limited to very few cases for now (non-chromeos, non-android,
non-official, component builds only).

BUG=371125
TBR=piman,dalecurtis

Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e
Cr-Commit-Position: refs/heads/master@{#312020}

Committed: https://crrev.com/fdaea4c9e63c845db9c009d236205e7ed4fcb663
Cr-Commit-Position: refs/heads/master@{#312032}

[Nico, 2015-01-17 01:11:35]

thakis@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-01-17 01:21:25]

https://codereview.chromium.org/854753002/diff/100001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtk2ui/libgtk2ui.gyp (right):

https://codereview.chromium.org/854753002/diff/100001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtk2ui/libgtk2ui.gyp:100: 'link_settings': { 'libraries': [
'-lX11' ] },
hmm, is there a reason you use link_settings here instead of depending on the
pkg-config pseudotarget? (i think build/linux/system.gyp:x11) ?

https://codereview.chromium.org/854753002/diff/100001/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/854753002/diff/100001/content/content_shell.g...
content/content_shell.gypi:734: 'link_settings': { 'libraries': [ '-lX11' ] },
same here

https://codereview.chromium.org/854753002/diff/100001/third_party/mesa/mesa.gyp
File third_party/mesa/mesa.gyp (right):

https://codereview.chromium.org/854753002/diff/100001/third_party/mesa/mesa.g...
third_party/mesa/mesa.gyp:690: '-lstdc++',
is this intentional?

[Nico, 2015-01-17 02:01:43]

Also added one -lrt that the trybots told me about. I expect that it'll tell me
about more.

https://codereview.chromium.org/854753002/diff/100001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtk2ui/libgtk2ui.gyp (right):

https://codereview.chromium.org/854753002/diff/100001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtk2ui/libgtk2ui.gyp:100: 'link_settings': { 'libraries': [
'-lX11' ] },
On 2015/01/17 01:21:25, jamesr wrote:
> hmm, is there a reason you use link_settings here instead of depending on the
> pkg-config pseudotarget? (i think build/linux/system.gyp:x11) ?

No. I looked at
https://code.google.com/p/chromium/codesearch#search/&q=lx11%20file:gyp&sq=pa...
and figured that's how this is done. Thanks, done.

https://codereview.chromium.org/854753002/diff/100001/third_party/mesa/mesa.gyp
File third_party/mesa/mesa.gyp (right):

https://codereview.chromium.org/854753002/diff/100001/third_party/mesa/mesa.g...
third_party/mesa/mesa.gyp:690: '-lstdc++',
On 2015/01/17 01:21:25, jamesr wrote:
> is this intentional?

Yes. If there are no .cc files in a target, gyp uses gcc instead of g++ (well,
clang instead of clang++) to link. It's not smart enough to figure out that a
static library it depends on contains a cc file. The fixes are adding a dummy cc
file, manually adding this flag, or making gyp smarter. For now, I'm going with
the explicit flag.

[jamesr, 2015-01-17 02:07:08]

lgtm

https://codereview.chromium.org/854753002/diff/120001/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/854753002/diff/120001/content/content_shell.g...
content/content_shell.gypi:734: 'link_settings': { 'libraries': [ '-lX11' ] },
system.gyp:x11

[Nico, 2015-01-17 03:18:17]

thakis@chromium.org changed reviewers:
+ dalecurtis@chromium.org, piman@chromium.org

[Nico, 2015-01-17 03:18:18]

Thanks! tbring.

piman: gpu, third_party/mesa
dalecurtis: media

https://codereview.chromium.org/854753002/diff/120001/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/854753002/diff/120001/content/content_shell.g...
content/content_shell.gypi:734: 'link_settings': { 'libraries': [ '-lX11' ] },
On 2015/01/17 02:07:08, jamesr wrote:
> system.gyp:x11

Done.

[Nico, 2015-01-17 03:18:58]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-17 03:19:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/854753002/140001

[commit-bot: I haz the power, 2015-01-17 03:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-17 03:26:44]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[Nico, 2015-01-17 03:56:11]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-17 03:57:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/854753002/160001

[commit-bot: I haz the power, 2015-01-17 04:58:48]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-01-17 04:59:37]

Patchset 9 (id:??) landed as
https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e
Cr-Commit-Position: refs/heads/master@{#312020}

[Lei Zhang, 2015-01-17 08:15:25]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/851313004/ by thestig@chromium.org.

The reason for reverting is: Broke Ozone:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

gyp: Dependency
'/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/build/linux/system.gyp:x11#target'
not found while trying to load target
/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/content/content_shell_and_tests.gyp:test_netscape_plugin#target
.

[Nico, 2015-01-17 08:48:39]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-17 08:48:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/854753002/180001

[commit-bot: I haz the power, 2015-01-17 09:51:49]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-01-17 09:52:43]

Patchset 10 (id:??) landed as
https://crrev.com/fdaea4c9e63c845db9c009d236205e7ed4fcb663
Cr-Commit-Position: refs/heads/master@{#312032}

[Michael Achenbach, 2015-01-18 10:49:11]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2015-01-18 10:49:12]

Possible that this breaks *SAN debug?
http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug/builds/9775/

The lkgr range between the last successful build and the failure is:
https://chromium.googlesource.com/chromium/src/+log/8be8b4d8e65c4d02219a3c692...

[Timothy Loh, 2015-01-19 05:19:18]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/835223006/ by timloh@chromium.org.

The reason for reverting is: Breaks compile on chromium.webkit/Linux Tests (dbg)
and probably also chromium.lkgr/ASAN Debug

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2...
http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug.