Swarm cc_unittests.

Swarm cc_unittests.

BUG=448877
Committed: https://crrev.com/9086ff0072268267bacf28e6098a7b5bd8478982
Cr-Commit-Position: refs/heads/master@{#312252}

[jam, 2015-01-14 21:15:36]

jam@chromium.org changed reviewers:
+ nduca@chromium.org

[jam, 2015-01-15 23:08:40]

jam@chromium.org changed reviewers:
+ maruel@chromium.org
- nduca@chromium.org

[jam, 2015-01-15 23:08:41]

->maruel

[M-A Ruel, 2015-01-15 23:39:17]

lgtm with one concern

https://codereview.chromium.org/854743002/diff/40001/cc/cc_unittests.isolate
File cc/cc_unittests.isolate (right):

https://codereview.chromium.org/854743002/diff/40001/cc/cc_unittests.isolate#...
cc/cc_unittests.isolate:30: '<(PRODUCT_DIR)/xdisplaycheck',
Someone had been switching this condition on use_x11==1. I think it'd be better.
It's related to ozone and chromeos tests. Sorry I forgot to note that in the
previous CLs you did recently.

[jam, 2015-01-16 00:03:16]

https://codereview.chromium.org/854743002/diff/40001/cc/cc_unittests.isolate
File cc/cc_unittests.isolate (right):

https://codereview.chromium.org/854743002/diff/40001/cc/cc_unittests.isolate#...
cc/cc_unittests.isolate:30: '<(PRODUCT_DIR)/xdisplaycheck',
On 2015/01/15 23:39:17, M-A Ruel wrote:
> Someone had been switching this condition on use_x11==1. I think it'd be
better.
> It's related to ozone and chromeos tests. Sorry I forgot to note that in the
> previous CLs you did recently.

ah, I had removed it since ozone isn't using swarming (they need special h/w).
so i thought no reason to complicate the isolate files until we need them to
support ozone, at which point updating all the files won't be hard?

[M-A Ruel, 2015-01-16 00:16:37]

https://codereview.chromium.org/854743002/diff/40001/cc/cc_unittests.isolate
File cc/cc_unittests.isolate (right):

https://codereview.chromium.org/854743002/diff/40001/cc/cc_unittests.isolate#...
cc/cc_unittests.isolate:30: '<(PRODUCT_DIR)/xdisplaycheck',
On 2015/01/16 00:03:15, jam wrote:
> On 2015/01/15 23:39:17, M-A Ruel wrote:
> > Someone had been switching this condition on use_x11==1. I think it'd be
> better.
> > It's related to ozone and chromeos tests. Sorry I forgot to note that in the
> > previous CLs you did recently.
> 
> ah, I had removed it since ozone isn't using swarming (they need special h/w).
> so i thought no reason to complicate the isolate files until we need them to
> support ozone, at which point updating all the files won't be hard?

Maybe it had broken compile? I don't mind really, it's easy to fix. Don't bother
too much with that, it was really just FYI.

[alexst (slow to review), 2015-01-16 14:05:29]

alexst@chromium.org changed reviewers:
+ alexst@chromium.org

[alexst (slow to review), 2015-01-16 14:05:29]

BTW, we are trying to enable swarming for ozone to add our bots to the CQ. We
can still test a lot without hardware.

[M-A Ruel, 2015-01-16 14:07:31]

On 2015/01/16 14:05:29, alexst wrote:
> BTW, we are trying to enable swarming for ozone to add our bots to the CQ. We
> can still test a lot without hardware.

Thanks Alex for the confirmation! Sorry I'm a bit on very short term memory in
that zone (Doris-style) on these days. :)

[jam, 2015-01-16 16:38:40]

On 2015/01/16 14:07:31, M-A Ruel wrote:
> On 2015/01/16 14:05:29, alexst wrote:
> > BTW, we are trying to enable swarming for ozone to add our bots to the CQ.
We
> > can still test a lot without hardware.
> 
> Thanks Alex for the confirmation! Sorry I'm a bit on very short term memory in
> that zone (Doris-style) on these days. :)

Thanks for the info, I'll separate it out.

[jam, 2015-01-20 17:37:45]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-01-20 17:38:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/854743002/80001

[commit-bot: I haz the power, 2015-01-20 18:28:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-20 18:28:11]

Failed to apply patch for testing/buildbot/chromium_memory_trybot.json:
While running git apply --index -3 -p1;
  error: patch failed: testing/buildbot/chromium_memory_trybot.json:15
  Falling back to three-way merge...
  Applied patch to 'testing/buildbot/chromium_memory_trybot.json' with
conflicts.
  U testing/buildbot/chromium_memory_trybot.json

Patch:       testing/buildbot/chromium_memory_trybot.json
Index: testing/buildbot/chromium_memory_trybot.json
diff --git a/testing/buildbot/chromium_memory_trybot.json
b/testing/buildbot/chromium_memory_trybot.json
index
2b8564e164ca1775ab355f0ca9e45de16a5d6920..090a10d67ca58c99638057a8d9c906c21b3843eb
100644
--- a/testing/buildbot/chromium_memory_trybot.json
+++ b/testing/buildbot/chromium_memory_trybot.json
@@ -15,7 +15,12 @@
       }
     },
     "cacheinvalidation_unittests",
-    "cc_unittests",
+    {
+      "test": "cc_unittests",
+      "swarming": {
+        "can_use_on_swarming_builders": true
+      }
+    },
     "components_unittests",
     {
       "test": "content_browsertests",

[commit-bot: I haz the power, 2015-01-20 18:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[jam, 2015-01-20 18:48:03]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-01-20 18:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/854743002/100001

[commit-bot: I haz the power, 2015-01-20 19:49:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-01-20 19:50:30]

Patchset 6 (id:??) landed as
https://crrev.com/9086ff0072268267bacf28e6098a7b5bd8478982
Cr-Commit-Position: refs/heads/master@{#312252}

[sergeyv, 2015-01-21 13:33:53]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/861173002/ by sergeyv@chromium.org.

The reason for reverting is: Failures on chrome.mac.