Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 8547005: CrOs: Remove 2 static initializers and 2 exit time destructors. (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai, stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

CrOs: Remove 2 static initializers and 2 exit time destructors. Turn on -Wexit-time-destructors for (most of) the chrome target. BUG=101600, 94925 TEST=none TBR=stevenjb Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110954

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M chrome/browser/chromeos/status/network_menu_icon.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/chrome.gyp View 16 chunks +16 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
9 years, 1 month ago (2011-11-21 06:48:41 UTC) #1
Mark Mentovai
LGTM
9 years, 1 month ago (2011-11-21 13:47:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8547005/2001
9 years, 1 month ago (2011-11-21 14:13:13 UTC) #3
commit-bot: I haz the power
Presubmit check for 8547005-2001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-21 14:13:18 UTC) #4
Nico
stevenjb: OWNERS stamp, please.
9 years, 1 month ago (2011-11-21 16:08:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8547005/2001
9 years, 1 month ago (2011-11-21 16:08:38 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 18:02:46 UTC) #7
Change committed as 110954

Powered by Google App Engine
This is Rietveld 408576698