Verify heartbeat messages have type 'license-renewal'

Verify heartbeat messages have type 'license-renewal'

Also check that non-heartbeat messages are 'license-request'.
Only done for unprefixed API.

BUG=442558
TEST=EME browser_tests pass

Committed: https://crrev.com/9e887ea15b89c3c446d3566904cfdd3350fb018b
Cr-Commit-Position: refs/heads/master@{#311796}

[jrummell, 2015-01-14 23:15:06]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org

[jrummell, 2015-01-14 23:15:06]

PTAL.

[ddorwin, 2015-01-14 23:24:52]

LG. Minor stuff.

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:47: if
(Utils.isHeartBeatMessage(message)) {
Rename isRenewalMessage?
"Heartbeat" isn't a concept in the spec, so we should prefer one that is
(renewal). We should probably change all other occurrences as well.

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:52: Utils.failTest('non-heart beat
message is not license-request',
'Unexpected message type "' message.messageType '" received.'

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
File media/test/data/eme_player_js/utils.js (right):

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/utils.js:206: if (message.messageType ==
'license-renewal') {
nit: Unless the rest of the code follows this pattern, "fail" early if !=.

[jrummell, 2015-01-15 01:32:56]

Updated.

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:47: if
(Utils.isHeartBeatMessage(message)) {
On 2015/01/14 23:24:52, ddorwin wrote:
> Rename isRenewalMessage?
> "Heartbeat" isn't a concept in the spec, so we should prefer one that is
> (renewal). We should probably change all other occurrences as well.

Done.

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:52: Utils.failTest('non-heart beat
message is not license-request',
On 2015/01/14 23:24:52, ddorwin wrote:
> 'Unexpected message type "' message.messageType '" received.'

Done.

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
File media/test/data/eme_player_js/utils.js (right):

https://codereview.chromium.org/854633003/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/utils.js:206: if (message.messageType ==
'license-renewal') {
On 2015/01/14 23:24:52, ddorwin wrote:
> nit: Unless the rest of the code follows this pattern, "fail" early if !=.

Done.

[ddorwin, 2015-01-15 03:31:51]

https://codereview.chromium.org/854633003/diff/20001/media/test/data/eme_play...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/854633003/diff/20001/media/test/data/eme_play...
media/test/data/eme_player_js/player_utils.js:132: if
(Utils.isHeartBeatMessage(message.message)) {
I meant we should rename this one too since "heartbeat" isn't a concept in
either (omitted in my comment) spec. So, s/heartbeat/renewal/ so we are using
the concrete concept from the current spec. That should be a much simpler change
in the HTML file.

[jrummell, 2015-01-15 19:38:00]

Updated to remove references to heartbeat.

https://codereview.chromium.org/854633003/diff/20001/media/test/data/eme_play...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/854633003/diff/20001/media/test/data/eme_play...
media/test/data/eme_player_js/player_utils.js:132: if
(Utils.isHeartBeatMessage(message.message)) {
On 2015/01/15 03:31:51, ddorwin wrote:
> I meant we should rename this one too since "heartbeat" isn't a concept in
> either (omitted in my comment) spec. So, s/heartbeat/renewal/ so we are using
> the concrete concept from the current spec. That should be a much simpler
change
> in the HTML file.

Done.

[ddorwin, 2015-01-15 19:56:43]

lgtm with nit

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player.html (right):

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player.html:72: // and renewalmessage for these tests.
nit: keyadded is lowercase because that's the event name. You can probably add a
space here: "renewal message"

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player_js/globals.js (right):

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player_js/globals.js:9: var RENEWAL_MESSAGE_HEADER =
'HEARTBEAT';
You could also change this in the .cc file. Or we can clean it up later.

[jrummell, 2015-01-15 21:55:34]

Thanks for the reviews.

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player.html (right):

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player.html:72: // and renewalmessage for these tests.
On 2015/01/15 19:56:43, ddorwin wrote:
> nit: keyadded is lowercase because that's the event name. You can probably add
a
> space here: "renewal message"

Done.

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player_js/globals.js (right):

https://codereview.chromium.org/854633003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player_js/globals.js:9: var RENEWAL_MESSAGE_HEADER =
'HEARTBEAT';
On 2015/01/15 19:56:43, ddorwin wrote:
> You could also change this in the .cc file. Or we can clean it up later.

Added to my cleanup list.

[jrummell, 2015-01-15 21:55:38]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-01-15 22:18:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/854633003/60001

[commit-bot: I haz the power, 2015-01-16 00:52:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-16 00:55:00]

Patchset 4 (id:??) landed as
https://crrev.com/9e887ea15b89c3c446d3566904cfdd3350fb018b
Cr-Commit-Position: refs/heads/master@{#311796}