Issue 854633002: Eagerly disable optimization of %_GeneratorThrow, %_GeneratorNext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 854633002: Eagerly disable optimization of %_GeneratorThrow, %_GeneratorNext (Closed)

Created:
5 years, 11 months ago by wingo

Modified:
5 years, 7 months ago

Reviewers:
Hannes Payer (out of office), Michael Starzinger (Google)

CC:
v8-dev. svenpanne_chromium.org, Michael Starzinger, Sven Panne

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Eagerly disable optimization of %_GeneratorThrow, %_GeneratorNext R=hpayer@chromium.org BUG=v8:3803 LOG=N

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	src/ast-numbering.cc	View		1 chunk	+13 lines, -0 lines	1 comment	Download
	M	src/hydrogen.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Starzinger (Google)

https://codereview.chromium.org/854633002/diff/1/src/ast-numbering.cc File src/ast-numbering.cc (right): https://codereview.chromium.org/854633002/diff/1/src/ast-numbering.cc#newcode300 src/ast-numbering.cc:300: if (function != NULL && function->intrinsic_type == Runtime::INLINE) { ...

5 years, 11 months ago (2015-01-14 20:42:22 UTC) #3

wingo

5 years, 11 months ago (2015-01-15 08:39:53 UTC) #4

On 2015/01/14 20:42:22, Michael Starzinger (Google) wrote:
> https://codereview.chromium.org/854633002/diff/1/src/ast-numbering.cc
> File src/ast-numbering.cc (right):
> 
>
https://codereview.chromium.org/854633002/diff/1/src/ast-numbering.cc#newcode300
> src/ast-numbering.cc:300: if (function != NULL && function->intrinsic_type ==
> Runtime::INLINE) {
> OMG, pretty please don't. Is this known to fix the problem mentioned in the
> issue or is it more a "stab in the dark"?

Stab in the dark!  The issue is a flaky failure that Hannes and I haven't been
able to reproduce locally.  See
http://code.google.com/p/v8/issues/detail?id=3803#c4.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages