src/core/SkBitmapProcState.cpp - Issue 85463005: remove SkFloatToScalar macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBitmapProcState.cpp

Issue 85463005: remove SkFloatToScalar macro (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: add failing test back Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkBitmapProcState.cpp

diff --git a/src/core/SkBitmapProcState.cpp b/src/core/SkBitmapProcState.cpp

index a535f086ea642921db8883325761b8af223951a1..59483d66a151ca6a4172a4c7289d4eb60a9949f1 100644

--- a/src/core/SkBitmapProcState.cpp

+++ b/src/core/SkBitmapProcState.cpp

@@ -198,7 +198,7 @@ bool SkBitmapProcState::possiblyScaleImage() {

// so we only keep High quality if the scale is greater than this.

// Since we're dealing with the inverse, we compare against its inverse.

- const SkScalar bicubicLimit = SkFloatToScalar(4.0f);

+ const SkScalar bicubicLimit = 4.0f;

const SkScalar bicubicLimitSqd = bicubicLimit * bicubicLimit;

if (scaleSqd < bicubicLimitSqd) { // use bicubic scanline

return false;