src/core/SkBBoxRecord.cpp - Issue 85463005: remove SkFloatToScalar macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBBoxRecord.cpp

Issue 85463005: remove SkFloatToScalar macro (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: add failing test back Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkBBoxRecord.cpp

diff --git a/src/core/SkBBoxRecord.cpp b/src/core/SkBBoxRecord.cpp

index 2349b1c3e10e255690434358d94608b21835dfda..cdb70bb7301c5f429b71a1bfb7a0a471e9eed613 100644

--- a/src/core/SkBBoxRecord.cpp

+++ b/src/core/SkBBoxRecord.cpp

@@ -53,7 +53,7 @@ void SkBBoxRecord::drawPoints(PointMode mode, size_t count, const SkPoint pts[],

// Note: The device coordinate outset in SkBBoxHierarchyRecord::handleBBox is currently

// done in the recording coordinate space, which is wrong.

// http://code.google.com/p/skia/issues/detail?id=1021

- static const SkScalar kMinWidth = SkFloatToScalar(0.01f);

+ static const SkScalar kMinWidth = 0.01f;

SkScalar halfStrokeWidth = SkMaxScalar(paint.getStrokeWidth(), kMinWidth) / 2;

bbox.outset(halfStrokeWidth, halfStrokeWidth);

if (this->transformBounds(bbox, &paint)) {