Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 854623002: Vector-based LoadICs need to handle Smi receivers. (Closed)

Created:
5 years, 11 months ago by mvstanton
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector-based LoadICs need to handle Smi receivers. The MISS handler was being called when the receiver was a Smi, instead, we should recognize the case and use the heap number map. BUG= Committed: https://crrev.com/23b181552e63aa3a6ee86ab0c99998dad44b7f14 Cr-Commit-Position: refs/heads/master@{#26076}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -38 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +43 lines, -38 lines 2 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mvstanton
Hi Yang, here is the change we discussed. Really helps Octane PdfJs (from -30% to ...
5 years, 11 months ago (2015-01-14 16:25:01 UTC) #2
Yang
lgtm with nit. https://codereview.chromium.org/854623002/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/854623002/diff/1/src/code-stubs-hydrogen.cc#newcode2042 src/code-stubs-hydrogen.cc:2042: Push(AddLoadMap(receiver, nullptr)); Don't we usually just ...
5 years, 11 months ago (2015-01-15 11:33:46 UTC) #3
mvstanton
Thanks Yang, landing... https://codereview.chromium.org/854623002/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/854623002/diff/1/src/code-stubs-hydrogen.cc#newcode2042 src/code-stubs-hydrogen.cc:2042: Push(AddLoadMap(receiver, nullptr)); On 2015/01/15 11:33:45, Yang ...
5 years, 11 months ago (2015-01-15 12:25:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854623002/1
5 years, 11 months ago (2015-01-15 12:26:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 12:52:44 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 12:52:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23b181552e63aa3a6ee86ab0c99998dad44b7f14
Cr-Commit-Position: refs/heads/master@{#26076}

Powered by Google App Engine
This is Rietveld 408576698