Issue 854603004: Sky events should be in dips rather than ddpxs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 854603004: Sky events should be in dips rather than ddpxs (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Sky events should be in dips rather than ddpxs Mojo events are in physical pixels but Sky works in logical pixels. This CL changes the code that converts from Mojo events to Sky events to scale by the device_pixel ratio. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ee97a07d286ae21d6f6bfb4c8084911939ec0b15

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -103 lines)			Patch
M	sky/viewer/converters/input_event_types.h	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	sky/viewer/converters/input_event_types.cc	View	14 chunks	+110 lines, -95 lines	0 comments	Download
M	sky/viewer/document_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 11 months ago (2015-01-14 21:50:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ee97a07d286ae21d6f6bfb4c8084911939ec0b15 (presubmit successful).