Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Side by Side Diff: sky/engine/core/rendering/RenderLayerScrollableArea.cpp

Issue 854563005: Remove some unused paint invalidation members from RenderObject. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: add a bit more Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBlockFlow.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 // We don't update compositing layers, because we need to do a deep update f rom the compositing ancestor. 235 // We don't update compositing layers, because we need to do a deep update f rom the compositing ancestor.
236 if (!frameView->isInPerformLayout()) { 236 if (!frameView->isInPerformLayout()) {
237 // If we're in the middle of layout, we'll just update layers once layou t has finished. 237 // If we're in the middle of layout, we'll just update layers once layou t has finished.
238 // FIXME(sky): Do we still need this? 238 // FIXME(sky): Do we still need this?
239 layer()->clipper().clearClipRectsIncludingDescendants(); 239 layer()->clipper().clearClipRectsIncludingDescendants();
240 } 240 }
241 241
242 // The caret rect needs to be invalidated after scrolling 242 // The caret rect needs to be invalidated after scrolling
243 frame->selection().setCaretRectNeedsUpdate(); 243 frame->selection().setCaretRectNeedsUpdate();
244 244
245 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(layer()->renderer()->previou sPaintInvalidationRect()); 245 // TODO(ojan): Is there a better way to get this value now that we always ju st pass the empty
246 246 // FloatQuat to localToAbsoluteQuad?
247 quadForFakeMouseMoveEvent = paintInvalidationContainer->localToAbsoluteQuad( quadForFakeMouseMoveEvent); 247 FloatQuad quadForFakeMouseMoveEvent = paintInvalidationContainer->localToAbs oluteQuad(FloatQuad());
248 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent); 248 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent);
249 249
250 // Schedule the scroll DOM event. 250 // Schedule the scroll DOM event.
251 if (box().node()) 251 if (box().node())
252 box().node()->document().enqueueScrollEventForNode(box().node()); 252 box().node()->document().enqueueScrollEventForNode(box().node());
253 } 253 }
254 254
255 IntPoint RenderLayerScrollableArea::scrollPosition() const 255 IntPoint RenderLayerScrollableArea::scrollPosition() const
256 { 256 {
257 return IntPoint(m_scrollOffset); 257 return IntPoint(m_scrollOffset);
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
755 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild) 755 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild)
756 { 756 {
757 // We only want to track the topmost scroll child for scrollable areas with 757 // We only want to track the topmost scroll child for scrollable areas with
758 // overlay scrollbars. 758 // overlay scrollbars.
759 if (!hasOverlayScrollbars()) 759 if (!hasOverlayScrollbars())
760 return; 760 return;
761 m_nextTopmostScrollChild = scrollChild; 761 m_nextTopmostScrollChild = scrollChild;
762 } 762 }
763 763
764 } // namespace blink 764 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderBlockFlow.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698