Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 854543002: ServiceWorker: Rename ScriptClientMap to ProviderClientMap (Closed)

Created:
5 years, 11 months ago by nhiroki
Modified:
5 years, 11 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Rename ScriptClientMap to ProviderClientMap ScriptClientMap actually contains provider clients, not script clients. BUG=n/a TEST=compile Committed: https://crrev.com/9029a481432057d4616e03b2b6fad0dd9c3e9e3f Cr-Commit-Position: refs/heads/master@{#311442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M content/child/service_worker/service_worker_dispatcher.h View 3 chunks +10 lines, -6 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
PTAL.
5 years, 11 months ago (2015-01-14 07:48:58 UTC) #2
kinuko
lgtm
5 years, 11 months ago (2015-01-14 09:13:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854543002/1
5 years, 11 months ago (2015-01-14 09:21:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 10:11:58 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 10:13:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9029a481432057d4616e03b2b6fad0dd9c3e9e3f
Cr-Commit-Position: refs/heads/master@{#311442}

Powered by Google App Engine
This is Rietveld 408576698