Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/mips/macro-assembler-mips.cc

Issue 85453002: Rollback of r18029 in bleeding_edge branch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/v8-counters.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 SmiCheck smi_check) { 268 SmiCheck smi_check) {
269 ASSERT(!AreAliased(object, address, value, t8)); 269 ASSERT(!AreAliased(object, address, value, t8));
270 ASSERT(!AreAliased(object, address, value, t9)); 270 ASSERT(!AreAliased(object, address, value, t9));
271 271
272 if (emit_debug_code()) { 272 if (emit_debug_code()) {
273 lw(at, MemOperand(address)); 273 lw(at, MemOperand(address));
274 Assert( 274 Assert(
275 eq, kWrongAddressOrValuePassedToRecordWrite, at, Operand(value)); 275 eq, kWrongAddressOrValuePassedToRecordWrite, at, Operand(value));
276 } 276 }
277 277
278 // Count number of write barriers in generated code.
279 isolate()->counters()->write_barriers_static()->Increment();
280 // TODO(mstarzinger): Dynamic counter missing.
281
282 // First, check if a write barrier is even needed. The tests below
283 // catch stores of smis and stores into the young generation.
284 Label done; 278 Label done;
285 279
286 if (smi_check == INLINE_SMI_CHECK) { 280 if (smi_check == INLINE_SMI_CHECK) {
287 ASSERT_EQ(0, kSmiTag); 281 ASSERT_EQ(0, kSmiTag);
288 JumpIfSmi(value, &done); 282 JumpIfSmi(value, &done);
289 } 283 }
290 284
291 CheckPageFlag(value, 285 CheckPageFlag(value,
292 value, // Used as scratch. 286 value, // Used as scratch.
293 MemoryChunk::kPointersToHereAreInterestingMask, 287 MemoryChunk::kPointersToHereAreInterestingMask,
(...skipping 5461 matching lines...) Expand 10 before | Expand all | Expand 10 after
5755 opcode == BGTZL); 5749 opcode == BGTZL);
5756 opcode = (cond == eq) ? BEQ : BNE; 5750 opcode = (cond == eq) ? BEQ : BNE;
5757 instr = (instr & ~kOpcodeMask) | opcode; 5751 instr = (instr & ~kOpcodeMask) | opcode;
5758 masm_.emit(instr); 5752 masm_.emit(instr);
5759 } 5753 }
5760 5754
5761 5755
5762 } } // namespace v8::internal 5756 } } // namespace v8::internal
5763 5757
5764 #endif // V8_TARGET_ARCH_MIPS 5758 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/v8-counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698