Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: android_webview/browser/renderer_host/print_manager.cc

Issue 854513002: Remove the discrepencies between chrome and android_webview print (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/renderer_host/print_manager.cc
diff --git a/android_webview/browser/renderer_host/print_manager.cc b/android_webview/browser/renderer_host/print_manager.cc
index 24fa3b49f8773d80091ec18890821a537748abb6..d5752fe29d8e2628fa2f275af1865186257e6bbd 100644
--- a/android_webview/browser/renderer_host/print_manager.cc
+++ b/android_webview/browser/renderer_host/print_manager.cc
@@ -17,8 +17,23 @@
using content::BrowserThread;
using printing::PrintSettings;
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(android_webview::PrintManager);
+
namespace android_webview {
+// static
+PrintManager* PrintManager::CreateForWebContents(
+ content::WebContents* contents,
+ PrintSettings* settings,
+ int fd,
+ PrintManagerDelegate* delegate) {
+ PrintManager* print_manager =
+ new PrintManager(contents, settings, fd, delegate);
+ contents->SetUserData(UserDataKey(), print_manager);
+ return print_manager;
+}
+
+
hush (inactive) 2015/01/14 01:55:47 stale line.
sgurun-gerrit only 2015/01/14 02:03:17 Done.
PrintManager::PrintManager(content::WebContents* contents,
PrintSettings* settings,
int fd,
@@ -45,10 +60,6 @@ bool PrintManager::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(PrintHostMsg_PrintingFailed, OnPrintingFailed)
IPC_MESSAGE_HANDLER_DELAY_REPLY(PrintHostMsg_GetDefaultPrintSettings,
OnGetDefaultPrintSettings)
- IPC_MESSAGE_HANDLER(PrintHostMsg_AllocateTempFileForPrinting,
- OnAllocateTempFileForPrinting)
- IPC_MESSAGE_HANDLER(PrintHostMsg_TempFileForPrintingWritten,
- OnTempFileForPrintingWritten)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()

Powered by Google App Engine
This is Rietveld 408576698