Remove the discrepencies between chrome and android_webview print

android_webview/native/aw_pdf_exporter.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_pdf_exporter.h"
 
-#include "android_webview/browser/renderer_host/print_manager.h"

[hush (inactive), 2015/01/14 01:55:47]

we still need print manager in this file?

[sgurun-gerrit only, 2015/01/14 02:03:17]

aw_pdf_exporter.h includes it since it implements PrintManagerDelegate.

 #include "base/android/jni_android.h"
 #include "base/logging.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents.h"
 #include "jni/AwPdfExporter_jni.h"
 #include "printing/print_settings.h"
 #include "printing/units.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ScopedJavaGlobalRef;
@@ skipping 23 matching lines @@
   // Clear the Java peer's weak pointer to |this| object.
   Java_AwPdfExporter_setNativeAwPdfExporter(env, obj.obj(), 0);
 }
 
 void AwPdfExporter::ExportToPdf(JNIEnv* env,
                                 jobject obj,
                                 int fd,
                                 jobject cancel_signal) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   CreatePdfSettings(env, obj);
-  print_manager_.reset(
-      new PrintManager(web_contents_, print_settings_.get(), fd, this));
-  if (!print_manager_->PrintNow())
+  PrintManager* print_manager =
+      PrintManager::CreateForWebContents(
+          web_contents_, print_settings_.get(), fd, this);
+   print_manager =

[boliu, 2015/01/14 01:41:02]

Why call CreateForWebContents with the exact same params twice?

Also indent

[hush (inactive), 2015/01/14 01:55:47]

print_manager is assigned 2 times?

[sgurun-gerrit only, 2015/01/14 02:03:17]

Done.

[sgurun-gerrit only, 2015/01/14 02:03:17]

Done.

+      PrintManager::CreateForWebContents(
+          web_contents_, print_settings_.get(), fd, this);
+  if (!print_manager->PrintNow())
     DidExportPdf(false);
 }
 
 namespace {
 // Converts from 1/1000 of inches to device units using DPI.
 int MilsToDots(int val, int dpi) {
   return static_cast<int>(ConvertUnitDouble(val, 1000.0, dpi));
 }
 
 }  // anonymous namespace
@@ skipping 44 matching lines @@
   // TODO(sgurun) implement. Needs connecting with the |cancel_signal| passed
   // in the constructor.
   return false;
 }
 
 bool RegisterAwPdfExporter(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android_webview