Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: chrome/utility/BUILD.gn

Issue 854503004: Fix some files in chrome directory for Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build on Linux and ChromeOS. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/metro_utils/BUILD.gn ('K') | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/BUILD.gn
diff --git a/chrome/utility/BUILD.gn b/chrome/utility/BUILD.gn
index fed82f85a4dd2f99dae8397f2f1908fcd1d9492d..a4ca50e18e41c4eef0629517d4b35e53fb80edb4 100644
--- a/chrome/utility/BUILD.gn
+++ b/chrome/utility/BUILD.gn
@@ -39,8 +39,6 @@ static_library("utility") {
deps += [
"//chrome/common/extensions/api",
"//extensions/utility",
-
- #"//third_party/libexif", TODO(GYP)
]
public_deps += [ "//chrome/common/extensions/api" ]
@@ -66,6 +64,12 @@ static_library("utility") {
".",
"..")
}
+
+ # Linux should use system libexif
+ if (!is_linux) {
+ # TODO(thestig): Properly support building on Linux and ChromeOS.
Slava Chigrin 2015/01/21 10:35:35 In https://codereview.chromium.org/809343008#msg6
+ deps += [ "//third_party/libexif" ]
+ }
}
if (use_openssl) {
« chrome/browser/metro_utils/BUILD.gn ('K') | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698