Chromium Code Reviews| Index: chrome/browser/BUILD.gn |
| diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn |
| index d210d1cf70adfe380e3de3fb555daf872130a725..b9b8d0a5821995ca3ffefbdd6e28f5d172d4532b 100644 |
| --- a/chrome/browser/BUILD.gn |
| +++ b/chrome/browser/BUILD.gn |
| @@ -485,6 +485,11 @@ static_library("browser") { |
| if (use_x11) { |
| sources += |
| rebase_path(gypi_values.chrome_browser_x11_sources, ".", "//chrome") |
| + } else { |
| + # In GYP that excluded by filename_rules.gypi, but GN analog - |
| + # sources_assignment_filter lacks of that filter, and comments there forbids |
| + # adding new rules to it. |
|
Dirk Pranke
2015/01/20 22:56:36
I would probably omit this comment.
|
| + sources -= [ "password_manager/password_store_x.cc" ] |
| } |
| if (is_posix && !is_mac && !is_ios) { |
| sources += [ |
| @@ -641,6 +646,7 @@ static_library("browser") { |
| deps += [ |
| "//chrome:version_header", |
| "//chrome/installer/util:strings", |
| + "//google_update", |
|
Slava Chigrin
2015/01/18 20:58:27
I've added it in https://codereview.chromium.org/8
|
| "//third_party/iaccessible2", |
| "//third_party/isimpledom", |
| "//third_party/wtl", |
| @@ -649,7 +655,6 @@ static_library("browser") { |
| #"../chrome_elf/chrome_elf.gyp:chrome_elf", TODO(GYP) |
| #"../chrome_elf/chrome_elf.gyp:chrome_elf_constants", TODO(GYP) |
| #"../chrome_elf/chrome_elf.gyp:dll_hash", TODO(GYP) |
| - #"../google_update/google_update.gyp:google_update", TODO(GYP) |
| "//ui/metro_viewer", |
| "//win8:metro_viewer", |
| ] |