Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 854503004: Fix some files in chrome directory for Windows GN build. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some files in chrome directory for Windows GN build. Committed: https://crrev.com/bbc23e733485b6efabc4ffbe2ad7b9becc4ea2e3 Cr-Commit-Position: refs/heads/master@{#312487}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix code style, remove unneeded comment. #

Patch Set 3 : Fix build on Linux and ChromeOS. #

Total comments: 2

Patch Set 4 : Fix sort order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/BUILD.gn View 1 3 chunks +3 lines, -1 line 0 comments Download
A + chrome/browser/metro_utils/BUILD.gn View 1 2 3 1 chunk +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/BUILD.gn View 1 2 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Slava Chigrin
https://codereview.chromium.org/854503004/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/854503004/diff/1/chrome/browser/BUILD.gn#newcode649 chrome/browser/BUILD.gn:649: "//google_update", I've added it in https://codereview.chromium.org/853643004 https://codereview.chromium.org/854503004/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn ...
5 years, 11 months ago (2015-01-18 20:58:27 UTC) #2
Dirk Pranke
lgtm w/ nit. https://codereview.chromium.org/854503004/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/854503004/diff/1/chrome/browser/BUILD.gn#newcode491 chrome/browser/BUILD.gn:491: # adding new rules to it. ...
5 years, 11 months ago (2015-01-20 22:56:36 UTC) #4
cpu_(ooo_6.6-7.5)
whatever dirk says, lgtm.
5 years, 11 months ago (2015-01-21 00:23:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854503004/20001
5 years, 11 months ago (2015-01-21 09:47:19 UTC) #7
Slava Chigrin
https://codereview.chromium.org/854503004/diff/60001/chrome/utility/BUILD.gn File chrome/utility/BUILD.gn (right): https://codereview.chromium.org/854503004/diff/60001/chrome/utility/BUILD.gn#newcode70 chrome/utility/BUILD.gn:70: # TODO(thestig): Properly support building on Linux and ChromeOS. ...
5 years, 11 months ago (2015-01-21 10:35:36 UTC) #11
Lei Zhang
lgtm https://codereview.chromium.org/854503004/diff/60001/chrome/browser/metro_utils/BUILD.gn File chrome/browser/metro_utils/BUILD.gn (right): https://codereview.chromium.org/854503004/diff/60001/chrome/browser/metro_utils/BUILD.gn#newcode7 chrome/browser/metro_utils/BUILD.gn:7: "//chrome/installer/util", nit: alphabetical order please
5 years, 11 months ago (2015-01-21 21:22:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854503004/60001
5 years, 11 months ago (2015-01-21 21:24:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854503004/80001
5 years, 11 months ago (2015-01-21 21:46:49 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 11 months ago (2015-01-21 22:49:54 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 22:50:52 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/bbc23e733485b6efabc4ffbe2ad7b9becc4ea2e3
Cr-Commit-Position: refs/heads/master@{#312487}

Powered by Google App Engine
This is Rietveld 408576698