Issue 854493004: Remove ForceDelete

Issue 854493004: Remove ForceDelete (Closed)

Created:
5 years, 11 months ago by Toon Verwaest

Modified:
5 years, 11 months ago

Reviewers:
dcarney

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove ForceDelete This method circumvented JS semantics, and should not be used. BUG= Committed: https://crrev.com/e99faf93ff85b5fc44dbf664c2d8294e7b071464 Cr-Commit-Position: refs/heads/master@{#26157}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -377 lines)			Patch
M	include/v8.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/api.cc	View	4 chunks	+4 lines, -23 lines	0 comments	Download
M	src/elements.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/elements.cc	View	9 chunks	+15 lines, -19 lines	0 comments	Download
M	src/objects.h	View	5 chunks	+12 lines, -32 lines	0 comments	Download
M	src/objects.cc	View	15 chunks	+67 lines, -95 lines	0 comments	Download
M	src/runtime/runtime-object.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+0 lines, -189 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	test/cctest/test-object-observe.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

dcarney

On 2015/01/14 17:27:49, Toon Verwaest wrote: > PTAL > I'll wait a week with landing. ...

5 years, 11 months ago (2015-01-14 18:47:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854493004/1

5 years, 11 months ago (2015-01-20 13:14:38 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-20 13:41:38 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e99faf93ff85b5fc44dbf664c2d8294e7b071464
Cr-Commit-Position: refs/heads/master@{#26157}