Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 854463003: Tell the QUIC AckNotifierManager about packets on serialization, rather (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index bedfb506f1448d5a160e5abc153f40fe3663ef50..d12fc0a7befa080eba6d5483c1e8c2f4d66dbd4c 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -1393,13 +1393,15 @@ class TestAckNotifierDelegate : public QuicAckNotifier::DelegateInterface {
bool has_been_notified_ = false;
};
-TEST_P(EndToEndTest, AckNotifierWithPacketLoss) {
- // Verify that even in the presence of packet loss, an AckNotifierDelegate
- // will get informed that the data it is interested in has been ACKed. This
- // tests end-to-end ACK notification, and demonstrates that retransmissions do
- // not break this functionality.
+TEST_P(EndToEndTest, AckNotifierWithPacketLossAndBlockedSocket) {
+ // Verify that even in the presence of packet loss and occasionally blocked
+ // socket, an AckNotifierDelegate will get informed that the data it is
+ // interested in has been ACKed. This tests end-to-end ACK notification, and
+ // demonstrates that retransmissions do not break this functionality.
ValueRestore<bool> old_flag(&FLAGS_quic_attach_ack_notifiers_to_packets,
true);
+ ValueRestore<bool> old_flag2(&FLAGS_quic_ack_notifier_informed_on_serialized,
+ true);
SetPacketLossPercentage(5);
ASSERT_TRUE(Initialize());
@@ -1407,6 +1409,7 @@ TEST_P(EndToEndTest, AckNotifierWithPacketLoss) {
// Wait for the server SHLO before upping the packet loss.
client_->client()->WaitForCryptoHandshakeConfirmed();
SetPacketLossPercentage(30);
+ client_writer_->set_fake_blocked_socket_percentage(10);
// Create a POST request and send the headers only.
HTTPMessage request(HttpConstants::HTTP_1_1, HttpConstants::POST, "/foo");
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698