Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 854433003: [Resources] Add profile-sized assets for the generic placeholder. (Closed)

Created:
5 years, 11 months ago by noms (inactive)
Modified:
5 years, 11 months ago
Reviewers:
Mike Lerman, oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Resources] Add profile-sized assets for the generic placeholder. The small, non-high res avatars are 38x31px assets, while the large generic placeholder is a square, which means that when displayed in the profile editing grid, it looks stretched out. BUG=438320 Committed: https://crrev.com/c941ac15694723f0e0117ffd70531f623956d46e Cr-Commit-Position: refs/heads/master@{#312122}

Patch Set 1 : add assets #

Patch Set 2 : the code bit #

Patch Set 3 : match variable name to asset file name #

Messages

Total messages: 8 (2 generated)
noms (inactive)
I added small profile-sized assets for the placeholder avatar so that it isn't stretched out ...
5 years, 11 months ago (2015-01-13 21:38:37 UTC) #2
oshima
c/a/theme lgtm
5 years, 11 months ago (2015-01-13 23:07:14 UTC) #3
Mike Lerman
lgtm "the code bits"
5 years, 11 months ago (2015-01-14 01:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854433003/40001
5 years, 11 months ago (2015-01-19 15:03:23 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-19 16:06:03 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 16:06:23 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c941ac15694723f0e0117ffd70531f623956d46e
Cr-Commit-Position: refs/heads/master@{#312122}

Powered by Google App Engine
This is Rietveld 408576698