views: Use ui::MessageBoxFlags::kIsJavascriptAlert where it's appropriate.

views: Use ui::MessageBoxFlags::kIsJavascriptAlert where it's appropriate.

R=sky@chromium.org

[sky, 2011-11-14 15:39:39]

Just because this code use the same constants as used by a javascript alert
dialogs doesn't mean we want to switch them to the constant. Javascript alert
has a very specific usage.

[tfarina, 2011-11-14 15:48:52]

On 2011/11/14 15:39:39, sky wrote:
> Just because this code use the same constants as used by a javascript alert
> dialogs doesn't mean we want to switch them to the constant. Javascript alert
> has a very specific usage.

This is just an intermediate step for http://codereview.chromium.org/8553001.
But not really necessary.

I hope to have made a clear idea of what I'm trying to accomplish/cleanup with
my comments in http://codereview.chromium.org/8536026/ and later with the patch
in http://codereview.chromium.org/8553001

I'll note that *none* of these flags passed to MessageBoxView
kIsConfirmDialog/kIsJavascriptAlert are used.

[tfarina, 2011-11-14 18:27:52]

On 2011/11/14 15:48:52, tfarina wrote:
> On 2011/11/14 15:39:39, sky wrote:
> > Just because this code use the same constants as used by a javascript alert
> > dialogs doesn't mean we want to switch them to the constant. Javascript
alert
> > has a very specific usage.
> 
> This is just an intermediate step for http://codereview.chromium.org/8553001.
> But not really necessary.
> 
> I hope to have made a clear idea of what I'm trying to accomplish/cleanup with
> my comments in http://codereview.chromium.org/8536026/ and later with the
patch
> in http://codereview.chromium.org/8553001
> 
> I'll note that *none* of these flags passed to MessageBoxView
> kIsConfirmDialog/kIsJavascriptAlert are used.

Scott, I'm closing this in favor of http://codereview.chromium.org/8553001/

As it makes this obsolete anyway!

PTAL!