src/x64/macro-assembler-x64.cc - Issue 854363003: fix debug checks for api callbacks returning symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 854363003: fix debug checks for api callbacks returning symbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 2932ec893cb2379f0bde24d2fbc67bd7e5a33cf4..97e5690c8dcf3a6b0a6c9aae4107ad57ffb89565 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -805,8 +805,8 @@ void MacroAssembler::CallApiFunctionAndReturn(

JumpIfSmi(return_value, &ok, Label::kNear);

movp(map, FieldOperand(return_value, HeapObject::kMapOffset));

- CmpInstanceType(map, FIRST_NONSTRING_TYPE);

- j(below, &ok, Label::kNear);

+ CmpInstanceType(map, LAST_NAME_TYPE);

+ j(below_equal, &ok, Label::kNear);

CmpInstanceType(map, FIRST_SPEC_OBJECT_TYPE);

j(above_equal, &ok, Label::kNear);

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »