Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 854363003: fix debug checks for api callbacks returning symbols (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

fix debug checks for api callbacks returning symbols BUG= Committed: https://crrev.com/3eb589976a979fa80f0934a3754ebc79d289b713 Cr-Commit-Position: refs/heads/master@{#26156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
lgtm
5 years, 11 months ago (2015-01-20 12:59:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854363003/1
5 years, 11 months ago (2015-01-20 13:00:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 13:27:53 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 13:28:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3eb589976a979fa80f0934a3754ebc79d289b713
Cr-Commit-Position: refs/heads/master@{#26156}

Powered by Google App Engine
This is Rietveld 408576698