sky/viewer/runtime_flags.h - Issue 854303002: Sky should use an SkPicture when drawing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/viewer/runtime_flags.h

Issue 854303002: Sky should use an SkPicture when drawing (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SKY_VIEWER_RUNTIME_FLAGS_H_

	6 #define SKY_VIEWER_RUNTIME_FLAGS_H_

	7

	8 namespace mojo {

	9 class ApplicationImpl;

	10 }

	11

	12 namespace sky {

	13

	14 struct RuntimeFlags {
	eseidel1 2015/01/20 02:04:03 No struct ever stays a struct. I'd just make this No struct ever stays a struct. I'd just make this a real class. A shame that c++ makes adding simple get/setters more difficult than it should. abarth-chromium 2015/01/20 02:47:38 Fixed. Show quoted text On 2015/01/20 at 02:04:03, eseidel1 wrote: > No struct ever stays a struct. I'd just make this a real class. A shame that c++ makes adding simple get/setters more difficult than it should. Fixed.
	15 bool testing;
	eseidel1 2015/01/20 02:04:03 Seems a bit strange, but OK. Seems a bit strange, but OK.
	16

	17 static void Initialize(mojo::ApplicationImpl* app);

	18 static const RuntimeFlags& Get();

	19 };

	20

	21 } // namespace sky

	22

	23 #endif // SKY_VIEWER_RUNTIME_FLAGS_H_

OLD	NEW