Chromium Code Reviews| Index: ui/display/util/edid_parser.h |
| diff --git a/ui/display/util/edid_parser.h b/ui/display/util/edid_parser.h |
| index 4f12d40aaa21074b3bc5e7e59f4e9e8e5d5a8d01..9a0acf54f26b19a05e2c17b9aafe4a6dd5112c96 100644 |
| --- a/ui/display/util/edid_parser.h |
| +++ b/ui/display/util/edid_parser.h |
| @@ -12,6 +12,10 @@ |
| #include "ui/display/util/display_util_export.h" |
| +namespace gfx { |
| +class Size; |
| +} |
| + |
| // EDID (Extended Display Identification Data) is a format for monitor |
| // metadata. This provides a parser for the data. |
| @@ -24,14 +28,16 @@ DISPLAY_UTIL_EXPORT bool GetDisplayIdFromEDID(const std::vector<uint8_t>& edid, |
| uint8_t index, |
| int64_t* display_id_out); |
| -// Parses |edid| as EDID data and stores extracted data into |manufacturer_id| |
| -// and |human_readable_name| and returns true. NULL can be passed for unwanted |
| -// output parameters. Some devices (especially internal displays) may not have |
| -// the field for |human_readable_name|, and it will return true in that case. |
| -DISPLAY_UTIL_EXPORT bool ParseOutputDeviceData( |
| - const std::vector<uint8_t>& edid, |
| - uint16_t* manufacturer_id, |
| - std::string* human_readable_name); |
| +// Parses |edid| as EDID data and stores extracted data into |manufacturer_id|, |
| +// |human_readable_name|, |pixel_out| and size_out, then returns true. NULL can |
|
dnicoara
2015/01/16 20:39:51
nit: |size_out|
oshima
2015/01/16 21:50:18
Done.
|
| +// be passed for unwanted output parameters. Some devices (especially internal |
| +// displays) may not have the field for |human_readable_name|, and it will |
| +// return true in that case. |
| +DISPLAY_UTIL_EXPORT bool ParseOutputDeviceData(const std::vector<uint8_t>& edid, |
| + uint16_t* manufacturer_id, |
| + std::string* human_readable_name, |
| + gfx::Size* pixel_out, |
|
dnicoara
2015/01/16 20:39:51
nit: I think it would be clearer if |pixel_out| an
oshima
2015/01/16 21:50:18
changed to active_pixel_out and physical_display_s
|
| + gfx::Size* size_out); |
| DISPLAY_UTIL_EXPORT bool ParseOutputOverscanFlag( |
| const std::vector<uint8_t>& edid, |