Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 854193003: tool --help alphabetizes command line flags (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

tool --help alphabetizes command line flags Committed: https://skia.googlesource.com/skia/+/03758b8c4a7f22c74a107905d8e16effab1c0442

Patch Set 1 #

Total comments: 2

Patch Set 2 : Another Patch Set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M gyp/flags.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 1 3 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hal.canary
ptal
5 years, 11 months ago (2015-01-16 15:34:08 UTC) #2
mtklein
lgtm, with some nits https://codereview.chromium.org/854193003/diff/1/tools/flags/SkCommandLineFlags.cpp File tools/flags/SkCommandLineFlags.cpp (right): https://codereview.chromium.org/854193003/diff/1/tools/flags/SkCommandLineFlags.cpp#newcode239 tools/flags/SkCommandLineFlags.cpp:239: SkTQSort(&allFlags[0], &allFlags[allFlags.count() - 1], c); ...
5 years, 11 months ago (2015-01-18 15:53:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854193003/20001
5 years, 11 months ago (2015-01-18 16:47:10 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-18 18:39:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/03758b8c4a7f22c74a107905d8e16effab1c0442

Powered by Google App Engine
This is Rietveld 408576698