Issue 854183002: ash: Cleanup - remove unused private fields.

Issue 854183002: ash: Cleanup - remove unused private fields. (Closed)

Created:
5 years, 11 months ago by tfarina

Modified:
5 years, 11 months ago

Reviewers:
James Cook

CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, hashimoto, sky

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

ash: Cleanup - remove unused private fields. BUG=447445 TEST=ash_unittests, ash_shell R=jamescook@chromium.org Committed: https://crrev.com/d7f1236fd77f7e7c252cf14bcfed811136777371 Cr-Commit-Position: refs/heads/master@{#311906}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -36 lines)			Patch
M	ash/display/mouse_cursor_event_filter_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/magnifier/partial_magnification_controller.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ash/magnifier/partial_magnification_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/popup_message.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ash/shell/window_type_launcher.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/chromeos/audio/audio_detailed_view.h	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	ash/system/chromeos/audio/audio_detailed_view.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	ash/system/chromeos/audio/tray_audio_chromeos.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/system/chromeos/network/tray_network.cc	View	4 chunks	+2 lines, -5 lines	0 comments	Download
M	ash/system/locale/locale_notification_controller.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/locale/locale_notification_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/system/tray/special_popup_row.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/test/ash_test_helper.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/test/ash_test_helper.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	ash/wm/panels/panel_window_resizer_unittest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

James Cook

Cool! How did you find these? Is there some new tool? LGTM!

5 years, 11 months ago (2015-01-16 15:16:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854183002/1

5 years, 11 months ago (2015-01-16 16:17:28 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-16 16:23:00 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d7f1236fd77f7e7c252cf14bcfed811136777371
Cr-Commit-Position: refs/heads/master@{#311906}