Add "OK, Google" and extended SafeBrowsing reporting to `chrome.privacy`

Add "OK, Google" and extended SafeBrowsing reporting to `chrome.privacy`

BUG=449500, 449499
Committed: https://crrev.com/134f2b1d3dd77442ef515f0980ff6612de2cbb37
Cr-Commit-Position: refs/heads/master@{#313491}

[Mike West, 2015-01-19 14:06:56]

mkwst@chromium.org changed reviewers:
+ kalman@chromium.org

[Mike West, 2015-01-19 14:06:56]

kalman@: WDYT?

[not at google - send to devlin, 2015-01-20 18:04:54]

kalman@chromium.org changed reviewers:
+ kcarattini@chromium.org, mattm@chromium.org

[not at google - send to devlin, 2015-01-20 18:04:55]

The sentiment SGTM, but CCing kcarattini and mattm on the hotwording and
safebrowsing sides who could give a more informed opinion.

https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/privacy.json (right):

https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/privacy.json:52:
"safeBrowsingExtendedReportingEnabled": {
Funny, how do you turn this on in the UI anyway?

[Mike West, 2015-01-20 18:56:44]

On 2015/01/20 18:04:55, kalman wrote:
> The sentiment SGTM, but CCing kcarattini and mattm on the hotwording and
> safebrowsing sides who could give a more informed opinion.

Great. Hi!

>
https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
> File chrome/common/extensions/api/privacy.json (right):
> 
>
https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
> chrome/common/extensions/api/privacy.json:52:
> "safeBrowsingExtendedReportingEnabled": {
> Funny, how do you turn this on in the UI anyway?

Either via advanced->privacy->"automatically report details of security...", or
by clicking an extra checkbox on a SafeBrowsing interstitial.

[kcarattini, 2015-01-21 02:00:25]

On 2015/01/20 18:56:44, Mike West wrote:
> On 2015/01/20 18:04:55, kalman wrote:
> > The sentiment SGTM, but CCing kcarattini and mattm on the hotwording and
> > safebrowsing sides who could give a more informed opinion.
> 
> Great. Hi!
> 
> >
>
https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
> > File chrome/common/extensions/api/privacy.json (right):
> > 
> >
>
https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
> > chrome/common/extensions/api/privacy.json:52:
> > "safeBrowsingExtendedReportingEnabled": {
> > Funny, how do you turn this on in the UI anyway?
> 
> Either via advanced->privacy->"automatically report details of security...",
or
> by clicking an extra checkbox on a SafeBrowsing interstitial.

Sorry, I'm not familiar with this code. What does adding the pref to
chrome.privacy entail? Why are you only adding the one and not both hotwording
prefs?

Thanks,
Kendra

[Mike West, 2015-01-21 10:17:32]

On 2015/01/21 02:00:25, kcarattini wrote:
> On 2015/01/20 18:56:44, Mike West wrote:
> > On 2015/01/20 18:04:55, kalman wrote:
> > > The sentiment SGTM, but CCing kcarattini and mattm on the hotwording and
> > > safebrowsing sides who could give a more informed opinion.
> > 
> > Great. Hi!
> > 
> > >
> >
>
https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
> > > File chrome/common/extensions/api/privacy.json (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/854153003/diff/1/chrome/common/extensions/api...
> > > chrome/common/extensions/api/privacy.json:52:
> > > "safeBrowsingExtendedReportingEnabled": {
> > > Funny, how do you turn this on in the UI anyway?
> > 
> > Either via advanced->privacy->"automatically report details of security...",
> or
> > by clicking an extra checkbox on a SafeBrowsing interstitial.
> 
> Sorry, I'm not familiar with this code. What does adding the pref to
> chrome.privacy entail? Why are you only adding the one and not both hotwording
> prefs?
> 
> Thanks,
> Kendra

Hi Kendra! This patch attempts to match the "Enable 'OK, Google' to start a
voice search" setting in the `chrome.privacy` extension API. That toggle seems
to only toggle the one hotwording pref. I assume the other you're talking about
is audio logging? I can add that as well; I forgot that we expose it on the
interstitial after clicking the checkbox.

[mattm, 2015-01-21 22:44:21]

SB lgtm

[kcarattini, 2015-01-22 00:56:59]

On 2015/01/21 22:44:21, mattm wrote:
> SB lgtm

lgtm.

The second hotwording pref is kHotwordAlwaysOnSearchEnabled, but we haven't
launched the functionality for that yet.

[Mike West, 2015-01-23 11:26:57]

kalman@, mind taking another look for OWNERS stamp?

[not at google - send to devlin, 2015-01-23 22:51:34]

lgtm

[Mike West, 2015-01-28 12:22:55]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-01-28 12:23:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/854153003/1

[commit-bot: I haz the power, 2015-01-28 12:58:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-28 12:58:53]

Patchset 1 (id:??) landed as
https://crrev.com/134f2b1d3dd77442ef515f0980ff6612de2cbb37
Cr-Commit-Position: refs/heads/master@{#313491}