Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 854063002: Update {virtual,override,final} to follow C++11 style chrome/browser/ui/webui/chromeos. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
xiyuan, Dan Beam
CC:
chromium-reviews, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style chrome/browser/ui/webui/chromeos. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=dbeam@chromium.org Committed: https://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a Cr-Commit-Position: refs/heads/master@{#312302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -152 lines) Patch
M chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/cryptohome_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/first_run/first_run_handler.h View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 4 chunks +12 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/network_config_message_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/network_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/nfc_debug_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc View 1 chunk +12 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/power_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/power_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/provided_file_systems_ui.cc View 1 chunk +13 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/salsa_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/set_time_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/set_time_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/slow_trace_ui.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/slow_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:22:09 UTC) #1
dcheng
+xiyuan
5 years, 11 months ago (2015-01-20 18:24:58 UTC) #3
xiyuan
lgtm
5 years, 11 months ago (2015-01-20 22:40:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854063002/1
5 years, 11 months ago (2015-01-20 22:41:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 00:21:04 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 00:21:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a
Cr-Commit-Position: refs/heads/master@{#312302}

Powered by Google App Engine
This is Rietveld 408576698