Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 854053002: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/ui. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
James Hawkins
CC:
aboxhall+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, stevenjb+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style chrome/browser/chromeos/ui. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=jhawkins@chromium.org Committed: https://crrev.com/da4362da0eed814fe3af6b5d38f8cd8147ba1b81 Cr-Commit-Position: refs/heads/master@{#311757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -80 lines) Patch
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/choose_mobile_network_dialog.h View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/ui/echo_dialog_view.h View 2 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_controller.h View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.h View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/ui/inline_login_dialog.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/ui/kiosk_external_update_notification.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ui/screen_capture_notification_ui_chromeos.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:17:03 UTC) #1
James Hawkins
lgtm
5 years, 11 months ago (2015-01-15 21:34:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854053002/1
5 years, 11 months ago (2015-01-15 21:38:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:08:50 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:10:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da4362da0eed814fe3af6b5d38f8cd8147ba1b81
Cr-Commit-Position: refs/heads/master@{#311757}

Powered by Google App Engine
This is Rietveld 408576698